fix: use synthetic mouse events for scrolling in apps#63
Merged
Conversation
This commit routes keyboard scroll actions through synthetic mouse wheel events when the foreground application has mouse mode enabled. Ratty's local scrollback is based on `vt100::Screen::set_scrollback(...)`, which works for scrollback Ratty actually owns. But apps like zellij already manage their own scrolling behavior and respond correctly to forwarded mouse wheel input. Reusing that same path for keyboard scroll bindings makes Alt+Up/Down behave consistently in those applications instead of relying on Ratty-local scrollback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit routes keyboard scroll actions through synthetic mouse wheel events
when the foreground application has mouse mode enabled.
Ratty's local scrollback is based on
vt100::Screen::set_scrollback(...),which works for scrollback Ratty actually owns. But apps like zellij already
manage their own scrolling behavior and respond correctly to
forwarded mouse wheel input.
Reusing that same path for keyboard scroll bindings makes Alt+Up/Down
behave consistently in those applications instead of relying on Ratty-local scrollback.
See #49