Skip to content

Shut down gracefully on window close#108

Merged
orhun merged 1 commit into
orhun:mainfrom
gold-silver-copper:fix-graceful-shutdown
Jun 11, 2026
Merged

Shut down gracefully on window close#108
orhun merged 1 commit into
orhun:mainfrom
gold-silver-copper:fix-graceful-shutdown

Conversation

@gold-silver-copper

@gold-silver-copper gold-silver-copper commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • emit AppExit directly when the primary window requests close
  • shut down the PTY runtime when Bevy exits
  • make PTY child/master/writer cleanup explicit and idempotent
  • keep Drop as a backup shutdown path for TerminalRuntime

orhun
orhun approved these changes Jun 11, 2026
View reviewed changes

@orhun orhun left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@orhun orhun merged commit 960315d into orhun:main Jun 11, 2026
11 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gold-silver-copper @orhun