Skip to content

Comments

feat(cli): add synergy between init and config flags#992

Merged
orhun merged 4 commits intoorhun:mainfrom
xsadia:add-synergy-between-init-and-config-flags
Jan 18, 2025
Merged

feat(cli): add synergy between init and config flags#992
orhun merged 4 commits intoorhun:mainfrom
xsadia:add-synergy-between-init-and-config-flags

Conversation

@xsadia
Copy link
Contributor

@xsadia xsadia commented Dec 26, 2024 •
edited
Loading

Description

Allow user to define init file by passing --config alongside to --init
closes #932

Motivation and Context

How Has This Been Tested?

Ran locally using --init and --config flags together as well as separate to make sure there where no breaking changes

Screenshots / Logs (if applicable)

image
image

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xsadia xsadia requested a review from orhun as a code owner December 26, 2024 00:12
@welcome
Copy link

welcome bot commented Dec 26, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 42.72%. Comparing base (e85888f) to head (f5d3e93).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
- Coverage   42.85%   42.72%   -0.13%     
==========================================
  Files          21       21              
  Lines        1734     1737       +3     
==========================================
- Hits          743      742       -1     
- Misses        991      995       +4
Flag Coverage Δ
unit-tests 42.72% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

orhun
orhun approved these changes Jan 18, 2025
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun merged commit 76bf9cf into orhun:main Jan 18, 2025
66 of 68 checks passed
@welcome
Copy link

welcome bot commented Jan 18, 2025

Congrats on merging your first pull request! ⛰️

@ricardoraposo
Copy link

ricardoraposo commented Jan 21, 2025

This is super poggers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

could we init with config to pyproject.toml?

4 participants

@xsadia @codecov-commenter @ricardoraposo @orhun