Skip to content

Comments

Docs imporovement in commit_preprocessors and commit_parsers#928

Merged
orhun merged 4 commits intoorhun:mainfrom
Muhammad-Owais-Warsi:main
Nov 3, 2024
Merged

Docs imporovement in commit_preprocessors and commit_parsers#928
orhun merged 4 commits intoorhun:mainfrom
Muhammad-Owais-Warsi:main

Conversation

@Muhammad-Owais-Warsi
Copy link
Contributor

@Muhammad-Owais-Warsi Muhammad-Owais-Warsi commented Oct 22, 2024 •
edited
Loading

Description

Improved the docs for more clarity under the following sections.

  1. commit_preprocessors
  2. commit_parsers

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@welcome
Copy link

welcome bot commented Oct 22, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.88%. Comparing base (99b78b5) to head (2535d41).
⚠️ Report is 198 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #928   +/-   ##
=======================================
  Coverage   42.88%   42.88%           
=======================================
  Files          21       21           
  Lines        1712     1712           
=======================================
  Hits          734      734           
  Misses        978      978
Flag Coverage Δ
unit-tests 42.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Muhammad-Owais-Warsi Muhammad-Owais-Warsi mentioned this pull request Oct 22, 2024
Closed
1 task
@Muhammad-Owais-Warsi
Copy link
Contributor Author

Muhammad-Owais-Warsi commented Oct 25, 2024

Hi @orhun , please let me know if there are still any changes to be made.

@orhun
Copy link
Owner

orhun commented Nov 3, 2024

Thanks!

@orhun orhun merged commit c1f1215 into orhun:main Nov 3, 2024
@welcome
Copy link

welcome bot commented Nov 3, 2024

Congrats on merging your first pull request! ⛰️

@Moisan Moisan mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Muhammad-Owais-Warsi @codecov-commenter @orhun