Skip to content

Comments

fix(remote): preserve first time contributors#925

Merged
orhun merged 5 commits intoorhun:mainfrom
mcwarman:fix/older-first-time-contributor
Oct 21, 2024
Merged

fix(remote): preserve first time contributors#925
orhun merged 5 commits intoorhun:mainfrom
mcwarman:fix/older-first-time-contributor

Conversation

@mcwarman
Copy link
Contributor

@mcwarman mcwarman commented Oct 19, 2024

Description

Preserve first time contributors in older change logs

Fixes #891

Motivation and Context

When a new release is created and all change logs regenerated the first time contributor section is removed.

How Has This Been Tested?

Tested using existing fixtures.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcwarman mcwarman requested a review from orhun as a code owner October 19, 2024 10:34
@mcwarman
Copy link
Contributor Author

mcwarman commented Oct 19, 2024 •
edited
Loading

My code follows the code style of this project.

I'm pretty very new to rust and I'm not entirely sure what I've done around date parsing is correct.

Feedback very welcome

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.98%. Comparing base (da1cb61) to head (f592cb6).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff-core/src/remote/mod.rs 75.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   41.57%   41.98%   +0.41%     
==========================================
  Files          21       21              
  Lines        1677     1694      +17     
==========================================
+ Hits          697      711      +14     
- Misses        980      983       +3
Flag Coverage Δ
unit-tests 41.98% <88.24%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcwarman
Copy link
Contributor Author

mcwarman commented Oct 19, 2024

I'll look at test coverage as well.

@orhun
Copy link
Owner

orhun commented Oct 19, 2024

Thanks for the PR! I will be reviewing this soon. No need to worry about test coverage or the code style for now.

Can you also update CHANGELOG.md file at the root of the repository by running git-cliff --latest with these changes? I want to see if the previously deleted first-time contributors will come back :)

@mcwarman
Copy link
Contributor Author

mcwarman commented Oct 19, 2024 •
edited
Loading

Updated the CHANGELOG.md, I had to run cargo run -- -o CHANGELOG.md and remove [unreleased] section manually.

--latest only returned latest tag.

orhun
orhun reviewed Oct 20, 2024
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The behavior seems to be fixed 👌🏼

I have one little comment.

@mcwarman
refactor: switch to using time
9939cb3 
- add test for timestamp method as well
@mcwarman mcwarman requested a review from orhun October 20, 2024 18:15
orhun
orhun approved these changes Oct 21, 2024
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! ❤️

@orhun orhun merged commit 99b78b5 into orhun:main Oct 21, 2024
@mcwarman mcwarman deleted the fix/older-first-time-contributor branch October 21, 2024 20:54
@Moisan Moisan mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix the first contributor filter

3 participants

@mcwarman @codecov-commenter @orhun