fix(changelog): fix missing commit fields in context (#837)#920
fix(changelog): fix missing commit fields in context (#837)#920orhun merged 1 commit intoorhun:mainfrom
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
- Coverage 41.57% 41.49% -0.07%
==========================================
Files 21 21
Lines 1677 1685 +8
==========================================
+ Hits 697 699 +2
- Misses 980 986 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dqkqd
force-pushed
the
issue-837
branch
2 times, most recently
from
a693040 to
52712d8
Compare
dqkqd
force-pushed
the
issue-837
branch
2 times, most recently
from
134d053 to
9dab742
Compare
orhun
left a comment
orhun
left a comment
There was a problem hiding this comment.
Neat!
Left some comments :) Also, can you update the documentation (in /website) about the existence of the new raw_message field?
dqkqd
force-pushed
the
issue-837
branch
2 times, most recently
from
04e064c to
f24e48d
Compare
|
I fixed according to your comments. |
There was a problem hiding this comment.
These test commits should no longer be needed. Can you test with an empty commit.sh and commit it if it works?
P.S. we should do the same for test-from-context fixture too.
There was a problem hiding this comment.
Sorry, it didn't work. I got an error, we must at least have one commit. I think this is a bug, but maybe we should fix this in another PR?
ERROR git_cliff > Git error: `reference 'refs/heads/main' not found; class=Reference (4); code=UnbornBranch (-9)`However, even if we don't use commit.sh, I think we should just keep it there, as a reference. I find it more difficult to read context.json compared to commit.sh
There was a problem hiding this comment.
Ah, okay. Yup, we need to fix that bug in another PR.
I find it more difficult to read context.json compared to commit.sh
Fair enough!
dqkqd
force-pushed
the
issue-837
branch
4 times, most recently
from
367ea95 to
3d96357
Compare
* feat(commit): add `raw_message` to `Commit` * test(fixtures): add test generate all fields in conventional commits * test(fixtures): add test do not discard missing fields in conventional commits when reading from context * docs(website): add `raw_message` fields to `context.md`
orhun
left a comment
orhun
left a comment
There was a problem hiding this comment.
This is great, thanks for your contribution!
|
Congrats on merging your first pull request! ⛰️ |
|
Hi @orhun, I just encountered this issue. Could you please make a release that includes this fix? |
|
Yup, I will try to do a release next week. |
Sorry to bother you, but any chance you could release it? |
|
released now :) |
4 participants
Description
Add new fields
raw_messageinCommitto avoid lossy message conversion.Fix #837
Motivation and Context
I implemented according to #837 (comment)
How Has This Been Tested?
Add 2 test fixtures
git cliff --context | git cliff --from-contextshould yield identical result withgit cliffScreenshots / Logs (if applicable)
Types of Changes
Checklist: