Skip to content

feat(bitbucket): add Bitbucket support#663

Merged
orhun merged 2 commits intoorhun:mainfrom
dark0dave:main
Jun 2, 2024
Merged

feat(bitbucket): add Bitbucket support#663
orhun merged 2 commits intoorhun:mainfrom
dark0dave:main

Conversation

@dark0dave
Copy link
Contributor

@dark0dave dark0dave commented May 29, 2024 •
edited
Loading

Description

Add bitbucket integration.

Closes #566

Motivation and Context

Add bitbucket integration.

How Has This Been Tested?

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 7.74648% with 131 lines in your changes are missing coverage. Please review.

Project coverage is 36.97%. Comparing base (2e1ed71) to head (674ae20).

Files Patch % Lines
git-cliff-core/src/remote/bitbucket.rs 0.00% 43 Missing ⚠️
git-cliff-core/src/remote/mod.rs 0.00% 32 Missing ⚠️
git-cliff-core/src/changelog.rs 27.78% 26 Missing ⚠️
git-cliff/src/lib.rs 0.00% 14 Missing ⚠️
git-cliff/src/logger.rs 0.00% 9 Missing ⚠️
git-cliff-core/src/remote/gitlab.rs 0.00% 4 Missing ⚠️
git-cliff-core/src/remote/github.rs 0.00% 2 Missing ⚠️
git-cliff-core/src/commit.rs 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
- Coverage   39.97%   36.97%   -3.00%     
==========================================
  Files          17       18       +1     
  Lines        1221     1350     +129     
==========================================
+ Hits          488      499      +11     
- Misses        733      851     +118
Flag Coverage Δ
unit-tests 36.97% <7.75%> (-3.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun
Copy link
Owner

orhun commented May 29, 2024

I created a repo for test fixtures: https://bitbucket.org/orhunp/git-cliff-readme-example

@dark0dave
Copy link
Contributor Author

dark0dave commented May 29, 2024

I created a repo for test fixtures: https://bitbucket.org/orhunp/git-cliff-readme-example

Big thanks, I was going to have to do that!

@dark0dave dark0dave force-pushed the main branch 3 times, most recently from 0121cd9 to 4913d88 Compare May 29, 2024 19:59
@orhun
Copy link
Owner

orhun commented May 31, 2024

How is this looking? I think I'm gonna release a new version on Monday so it would be nice to get this in :D

@dark0dave
Copy link
Contributor Author

dark0dave commented May 31, 2024

@orhun still fixing some bugs, bitbucket has weird author structure.

@dark0dave dark0dave force-pushed the main branch 7 times, most recently from 80c26eb to 3a6b966 Compare June 2, 2024 11:52
@dark0dave dark0dave changed the title Draft: feat(bitbucket): Closes #566 feat(bitbucket): Closes #566 Jun 2, 2024
@dark0dave dark0dave marked this pull request as ready for review June 2, 2024 11:53
@dark0dave dark0dave requested a review from orhun as a code owner June 2, 2024 11:53
@orhun orhun changed the title feat(bitbucket): Closes #566 feat(bitbucket): add Bitbucket support Jun 2, 2024
orhun
orhun approved these changes Jun 2, 2024
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@orhun orhun merged commit 8ffc054 into orhun:main Jun 2, 2024
@welcome
Copy link

welcome bot commented Jun 2, 2024

Congrats on merging your first pull request! ⛰️

@orhun orhun mentioned this pull request Jun 2, 2024
Closed
1 task
@Theta-Dev Theta-Dev mentioned this pull request Jun 6, 2024
Merged
12 tasks
@amd989 amd989 mentioned this pull request Oct 11, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bitbucket Integration

3 participants

@dark0dave @codecov-commenter @orhun