Skip to content

Comments

feat(args): add offline flag#1321

Merged
orhun merged 3 commits intoorhun:mainfrom
barskern:add-offline-flag
Jan 17, 2026
Merged

feat(args): add offline flag#1321
orhun merged 3 commits intoorhun:mainfrom
barskern:add-offline-flag

Conversation

@barskern
Copy link
Contributor

@barskern barskern commented Dec 19, 2025 •
edited
Loading

Description

Add a --offline flag to enable running e.g. --bumped-version without contacting any external services, even if they are configured. Closes #1095.

Motivation and Context

See #1095 .

How Has This Been Tested?

Local unit and integration tests, including building and running the binary in my local repo.

NOTE! Three unrelated tests were failing when I started my implementation:

repo::test::get_latest_tag
repo::test::git_tags
repo::test::resolves_existing_tag_with_name_and_message

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@barskern barskern requested a review from orhun as a code owner December 19, 2025 13:59
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.43%. Comparing base (d7a47bb) to head (ab05823).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 2 Missing ⚠️
git-cliff/src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
- Coverage   43.44%   43.43%   -0.00%     
==========================================
  Files          23       23              
  Lines        2247     2252       +5     
==========================================
+ Hits          976      978       +2     
- Misses       1271     1274       +3
Flag Coverage Δ
unit-tests 43.43% <50.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

orhun
orhun reviewed Dec 21, 2025
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also we need to update the documentation/website about this new flag :)

@barskern
Copy link
Contributor Author

barskern commented Jan 6, 2026

Looks good! Also we need to update the documentation/website about this new flag :)

Thank you for your patience here! I've added your suggested changes and a small section to the website. I was also looking for a way to test it, but in the way the remote module is implemented for the moment I wasn't able to find a clean way to do it. It seems like the remote implementations are not really tested for the moment?

@barskern barskern requested a review from orhun January 6, 2026 09:02
@orhun
Copy link
Owner

orhun commented Jan 8, 2026

Check out the test fixtures here. I believe we can copy one of the GitHub integration ones, run it with --offline and compare the result (expected.md).

@barskern
Copy link
Contributor Author

barskern commented Jan 16, 2026 •
edited
Loading

It was good that you requested me to create a test! My ignorance thought this was a trivial change, but making the test made me catch a edge-case. Thank you!

@barskern barskern changed the title feat(remote): add offline flag feat(args): add offline flag Jan 16, 2026
orhun
orhun approved these changes Jan 17, 2026
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@orhun orhun merged commit f19f1cd into orhun:main Jan 17, 2026
98 checks passed
@welcome
Copy link

welcome bot commented Jan 17, 2026

Congrats on merging your first pull request! ⛰️

@W1M0R
Copy link

W1M0R commented Jan 17, 2026

Thank you for this feature @barskern and @orhun!

@BrewTestBot BrewTestBot mentioned this pull request Jan 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add offline/local version of --bumped-version

4 participants

@barskern @codecov-commenter @orhun @W1M0R