Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
- Coverage 43.65% 43.43% -0.21%
==========================================
Files 22 22
Lines 1982 1978 -4
==========================================
- Hits 865 859 -6
- Misses 1117 1119 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ognis1205
left a comment
ognis1205
left a comment
There was a problem hiding this comment.
LGTM!
All tests passed on my local run except repo::test::get_latest_tag, repo::test::git_tags and repo::test::resolves_existing_tag_with_name_and_message, which I suspect failed because it was a local run
For verifying tests locally, you can follow the instructions in the Contributing Guide.
|
Congrats on merging your first pull request! ⛰️ |
4 participants
Description
Update
Cargo.lockMotivation and Context
When I updated git cliff with
cargo update --locked, cargo warned me about a yanked version of a dependency of a dependency. Thus, I runcargo updateand crated a commit with all the changesHow Has This Been Tested?
All tests passed on my local run except
repo::test::get_latest_tag,repo::test::git_tagsandrepo::test::resolves_existing_tag_with_name_and_message, which I suspect failed because it was a local runTypes of Changes
Checklist: