Skip to content

fix(config): link to tree for first tag#1250

Merged
orhun merged 1 commit intoorhun:mainfrom
mrdomino:mrdomino-patch-1
Sep 18, 2025
Merged

fix(config): link to tree for first tag#1250
orhun merged 1 commit intoorhun:mainfrom
mrdomino:mrdomino-patch-1

Conversation

@mrdomino
Copy link
Contributor

@mrdomino mrdomino commented Sep 13, 2025 •
edited
Loading

Description

In the keepachangelog config template, if there is not a prior tag, then link the first tag to the tree at that tag instead of not emitting a link at all.

Motivation and Context

This fixes the first release version in the keepachangelog format not being linkified.

How Has This Been Tested?

I ran this against a test repo locally.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mrdomino
fix(config): link to tree for first tag
af9dc89 
If there is not a prior commit, then link to the tree at that commit. This fixes the first release version in the `keepachangelog` format not being linkified.
@mrdomino mrdomino requested a review from orhun as a code owner September 13, 2025 03:53
@welcome
Copy link

welcome bot commented Sep 13, 2025

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.43%. Comparing base (9857d86) to head (af9dc89).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1250      +/-   ##
==========================================
- Coverage   43.65%   43.43%   -0.21%     
==========================================
  Files          22       22              
  Lines        1982     1978       -4     
==========================================
- Hits          865      859       -6     
- Misses       1117     1119       +2
Flag Coverage Δ
unit-tests 43.43% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

orhun
orhun approved these changes Sep 18, 2025
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@orhun orhun merged commit c0c4bf7 into orhun:main Sep 18, 2025
91 checks passed
@welcome
Copy link

welcome bot commented Sep 18, 2025

Congrats on merging your first pull request! ⛰️

@BrewTestBot BrewTestBot mentioned this pull request Sep 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrdomino @codecov-commenter @orhun