fix: check if commit.footers is defined in detailed example#1170
Merged
orhun merged 2 commits intoorhun:mainfrom Jun 7, 2025
gmeligio:empty_commit_footers
Merged
fix: check if commit.footers is defined in detailed example#1170orhun merged 2 commits intoorhun:mainfrom gmeligio:empty_commit_footers
orhun merged 2 commits intoorhun:mainfrom
gmeligio:empty_commit_footers
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1170 +/- ##
=======================================
Coverage 41.95% 41.95%
=======================================
Files 21 21
Lines 1981 1981
=======================================
Hits 831 831
Misses 1150 1150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Congrats on merging your first pull request! ⛰️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check if the
commit.footersarray was defined in the body template. An alternative would be to always passcommit.footersand empty if there are no footers. I don't have enough Rust knowledge to make that change related to #97.Motivation and Context
The change is required to fix a bug in
examples/detailed.toml. That configuration assumes that all the commits will have a footer. This is a bug when rendering thebodytemplate because sometimes there could be commits without footers because the PR author merged without a footer.How Has This Been Tested?
Creating a
detailed.tomlconfiguration in my private repository and applying the fix.Screenshots / Logs (if applicable)
Variable
commit.footersnot found in context while rendering 'body'Types of Changes
Checklist: