Skip to content

Comments

feat(context): add release commit range#1138

Merged
orhun merged 1 commit intoorhun:mainfrom
jdrst:feature/commit_range
Apr 30, 2025
Merged

feat(context): add release commit range#1138
orhun merged 1 commit intoorhun:mainfrom
jdrst:feature/commit_range

Conversation

@jdrst
Copy link
Contributor

@jdrst jdrst commented Apr 28, 2025

Description

Adds the used commit_range for each release.
commit_range includes the full length commit ids (commit_range.from and commit_range.to)
Also added related docs (and documentation for the sort_commits default)

Motivation and Context

See #1041

How Has This Been Tested?

Via integration_test and three new fixtures.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

random sideinfo:
repo::test::propagate_error_if_no_repo_found fails under windows.
clippy also reports errors under windows.

@jdrst jdrst requested a review from orhun as a code owner April 28, 2025 14:24
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 40.04%. Comparing base (451a694) to head (9030e40).

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
- Coverage   40.16%   40.04%   -0.12%     
==========================================
  Files          21       21              
  Lines        1900     1911      +11     
==========================================
+ Hits          763      765       +2     
- Misses       1137     1146       +9
Flag Coverage Δ
unit-tests 40.04% <23.08%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jdrst
Copy link
Contributor Author

jdrst commented Apr 28, 2025

ah interesting. i just updated my toolchain under windows so the clippy errors (and the linting error here) are probably explained by that.

orhun
orhun reviewed Apr 28, 2025
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, thanks for reopening the PR!

Only got one question

orhun
orhun reviewed Apr 29, 2025
View reviewed changes
@jdrst jdrst force-pushed the feature/commit_range branch from b384e40 to 945a05a Compare April 29, 2025 14:12
@jdrst jdrst force-pushed the feature/commit_range branch from 945a05a to 9030e40 Compare April 29, 2025 14:51
orhun
orhun approved these changes Apr 30, 2025
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for bearing with me!

@orhun orhun merged commit 3dab0d1 into orhun:main Apr 30, 2025
82 of 83 checks passed
@welcome
Copy link

welcome bot commented Apr 30, 2025

Congrats on merging your first pull request! ⛰️

@jdrst
Copy link
Contributor Author

jdrst commented Apr 30, 2025

Awesome, thanks for bearing with me!

Same to you :D

@BrewTestBot BrewTestBot mentioned this pull request Jun 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdrst @codecov-commenter @orhun