fix: first release wrong for submodules with custom range#1136
Merged
orhun merged 2 commits intoorhun:mainfrom Apr 26, 2025
Merged
fix: first release wrong for submodules with custom range#1136orhun merged 2 commits intoorhun:mainfrom
orhun merged 2 commits intoorhun:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
==========================================
- Coverage 40.13% 40.11% -0.02%
==========================================
Files 21 21
Lines 1899 1900 +1
==========================================
Hits 762 762
- Misses 1137 1138 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lehmanju
force-pushed
the
submodules-custom-range
branch
from
64fcf45 to
84f490e
Compare
orhun
reviewed
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Submodule changelogs are wrong if a custom range is supplied. The issue is that during submodule recursion, the previous release of the first release doesn't have a commit id attached. As a consequence the first release contains all commits, completely ignoring the range.
How Has This Been Tested?
Added a github fixture test.
Types of Changes
Checklist: