docs: Added dash to all samples#1051
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
=======================================
Coverage 41.94% 41.94%
=======================================
Files 21 21
Lines 1786 1786
=======================================
Hits 749 749
Misses 1037 1037
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hello, good catch!
What kind of errors did you get? Normally using either of I agree that there might be inconsistencies in the docs and we should fix them. It's a matter of which style we want to go for I guess :) |
|
Arh ok, I've mostly run in through |
|
Ah, certainly. Both forms of |
|
Sure, it's your decision at the end of the day. :) Just wanted to help out and make it more consistant, as many of the examples that uses both syntaxes looks like typos. |
|
I personally like the Instead of updating usages, I'd prefer we add a note about:
Would you be down to update this PR based on this? 😊 |
|
Cool, I respect that. Yes, will update the PR. Great tool btw! 🙌 |
|
Great, thank you <3 Ping me whenever this is ready for a review :) |
|
I've reverted to minor changes. 😊 Should be ready now. |
|
Congrats on merging your first pull request! ⛰️ |
Description
Docs were inconsistent and gave errors when copy and pasting.
Looked like a polyfill for git, which I guess isn't the intention.
Types of Changes