Bootstrap
Accordion button border color is changed on focus but its width is always 0 #39559
-
|
The accordion button border color is change on focus https://github.com/twbs/bootstrap/blob/main/scss/_accordion.scss#L77, but its border with is always equal to 0 https://github.com/twbs/bootstrap/blob/main/scss/_accordion.scss#L42. Is this expected? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 4 replies
-
|
Hey @SalimBensiali |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @julien-deramond. Is it then necessary to set a border color on button hover if the border is always 0? |
Beta Was this translation helpful? Give feedback.
-
|
I don't think so. I haven't checked really in detail but |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for reporting that @SalimBensiali |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @julien-deramond and for the prompt PR to address this. 👏 |
Beta Was this translation helpful? Give feedback.
I don't think so. I haven't checked really in detail but
--bs-accordion-btn-focus-border-colorandborder-color: var(--#{$prefix}accordion-btn-focus-border-color)(in&:focus) now seem to be useless because the rendering of the focus state is handled by the box shadow and the border width is always 0 anyway (without any way to override it for customization from the outside of the component).