Repository navigation
chore: bump minimum Go version to 1.26 - #1417
Conversation
Signed-off-by: Ricky-7-Yan <[email protected]>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1417 +/- ##
==========================================
+ Coverage 85.14% 90.85% +5.71%
==========================================
Files 95 95
Lines 7283 7283
==========================================
+ Hits 6201 6617 +416
+ Misses 657 654 -3
+ Partials 425 12 -413 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The dependency license check runs via apache/skywalking-eyes, whose composite action pins its own Go 1.25 toolchain and exports GOTOOLCHAIN=local. With go.mod now requiring go >= 1.26.0, license-eye fails to resolve the module graph: go: go.mod requires go >= 1.26.0 (running go 1.25.14; GOTOOLCHAIN=local) Set GOTOOLCHAIN=auto on the job so the required toolchain can be fetched. Upstream has no release that pins a newer Go: v0.9.0 is the latest and main still hardcodes go-version: 1.25. Signed-off-by: Terry Howe <[email protected]>
Signed-off-by: Ricky-7-Yan <[email protected]>
|
Thanks @TerryHowe — your diagnosis was right. The remaining failure came from the dependency composite action exporting GOTOOLCHAIN=local after the job-level setting, as confirmed by the failed log. I pushed fe30450: the header action still installs and runs the same license-eye binary, while the dependency check now invokes that binary directly with a step-level GOTOOLCHAIN=auto. This keeps the scanner/config unchanged and avoids the composite action's internal Go 1.25 reset. actionlint v1.7.12 and git diff --check pass locally; CI is rerunning. |
|
Thanks! |
Closes #1416.
Summary
Validation
go mod tidywith Go 1.26.0 (nogo.sumchanges)go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run(0 issues)CGO_ENABLED=0 go test -coverprofile=coverage.txt -covermode=atomic ./...on Linux/amd64 as a non-root user (all packages passed)git diff --check