Add github action to use latest buildtools snapshot and add it to CI#975
Add github action to use latest buildtools snapshot and add it to CI#975jormundur00 merged 6 commits intomasterfrom
Conversation
| - name: "☁️ Checkout repository" | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: "🛠️ Setup latest native-build-tools snapshot" |
There was a problem hiding this comment.
Well, this should be optional, right? We want to test with the latest release always, but on demand we can enable this.
There was a problem hiding this comment.
I believe we will need to test with the snapshot only (so no latest-release) in the time between us merging the metadata/index.json removal PR (both here and on buildtools) and the buildtools release including that PR releasing on the central Maven repository (otherwise, no PRs would be able to be merged in the meantime).
After that, I think we can remove this step of the workflows and on demand return it if a scenario like this arises again.
There was a problem hiding this comment.
Just add a variable to be able disable this.
There was a problem hiding this comment.
Per our offline discussion I added the following:
- The action is disabled by default (has a variable named
enabled-by-defaultwhich is currently set to false), - The action WILL run (even if disabled by default) if there is a branch of the same name on the NBT repository,
- Short section in
CI.mdexplaining this.
enabled-by-default will then temporarily be set to true once index.json removal is merged (until the new NBT release is released and added here).
jormundur00
force-pushed
the
jormundur00/gh-966
branch
from
410111c to
4ea1a53
Compare
|
Changes LGTM. |
jormundur00
force-pushed
the
jormundur00/gh-966
branch
from
053e12a to
90c2a1c
Compare
jormundur00
force-pushed
the
jormundur00/gh-966
branch
from
90c2a1c to
fa0113f
Compare
jormundur00
force-pushed
the
jormundur00/gh-966
branch
from
bbac538 to
a7f7434
Compare
jormundur00
force-pushed
the
jormundur00/gh-966
branch
from
0d4f6b2 to
99149ef
Compare
jormundur00
force-pushed
the
jormundur00/gh-966
branch
from
99149ef to
1dff0c0
Compare
3 participants
What does this PR do?
In this PR we introduce the
setup-native-build-toolsGitHub action that builds the latest Native Build Tools snapshot and sets the buildtools version inlibs.versions.tomlto that snapshot. This allows us to test the Reachability Metadata repositories CI with the latest buildtools changes. This is a requirement for merging PR whose changes create circular dependencies between the two repositories, while also allowing the CI to run without breaking in the time it takes to release new buildtools releases.The newly added action is fully-customizable through its inputs, where
nbt-refcan be used to make specific PRs run their CI on different Native Build Tools branches, if that is needed (and it will be needed for #960).We can most likely stop using this action in our workflows once the new release of NBT is released (with the big refactoring changes), to stay consistent with "stable" NBT releases, but we should still keep the action in the repository for future changes like this. The
test-all-metadataworkflow was ran on this PR with the latest NBT snapshot and it passes (workflow run).Fixes: #966