Skip to content

Add initial set of hibernate-core 7.2 metadata #896

Merged
kimeta merged 3 commits intooracle:masterfrom
christophstrobl:labs/hibernate-7.2
Dec 19, 2025
Merged

Add initial set of hibernate-core 7.2 metadata #896
kimeta merged 3 commits intooracle:masterfrom
christophstrobl:labs/hibernate-7.2

Conversation

@christophstrobl
Copy link
Copy Markdown
Contributor

What does this PR do?

Add metadata for hibernate-core 7.2 which added a few new requirements for reflection configuration.

Checklist before merging

# You should have received a copy of the CC0 legalcode along with this
# work. If not, see <http://creativecommons.org/publicdomain/zero/1.0/>.

../../../../../gradlew deleteGeneratedMetadata
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimeta how would this work with your latest automatic fixes? Maybe we need to augment our scripts to catch also generate-metadata.sh?

We should add this then into the CONTRIBUTING.md guide.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think generate-metadata.sh should be priority if it exists.

{"excludeClasses": "com.sun.**"},
{"excludeClasses": "java.**"},
{"excludeClasses": "org.slf4j.**"},
{"excludeClasses": "org_hibernate_orm.hibernate_core.entity.**"},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these included?

@@ -0,0 +1,49 @@
{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any manual entries in this PR?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it does, can you put it in the README.md in the library's test suite (tests/src/org.hibernate.orm/hibernate-core/7.1.0.Final/README.md). In the future we will have a field that marks if an entry is manually added.

@vjovanov vjovanov requested a review from kimeta December 18, 2025 02:25
@kimeta
Copy link
Copy Markdown
Collaborator

kimeta commented Dec 19, 2025

@christophstrobl Does the test directory from 7.2.0.Final differ at all to 7.1.0.Final? In the case it doesn't, we shouldn't create a new test directory for this library, but rather just create a new directory for the metadata. We create new test directories for a library only if its version introduces breaking changes that require any test adjustments.

@christophstrobl
Copy link
Copy Markdown
Contributor Author

@kimeta feel free to modify as needed. I did not add any new tests.

@kimeta kimeta force-pushed the labs/hibernate-7.2 branch from ae43978 to b50c8cb Compare December 19, 2025 17:55
@kimeta
Copy link
Copy Markdown
Collaborator

kimeta commented Dec 19, 2025

@christophstrobl I deleted test, rebased to the new master, and adapted metadata/org.hibernate.orm/hibernate-core/index.json to the new format.

@kimeta kimeta merged commit a203f30 into oracle:master Dec 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants