Assign random ports in Netty tests to prevent BindException #871
Merged
Assign random ports in Netty tests to prevent BindException #871
Conversation
36eda07 to
0a9e906
Compare
0a9e906 to
9c5d4c4
Compare
vjovanov
approved these changes
Dec 10, 2025
Member
|
@jormundur00 This should run all the netty versions, but it ended up running most of the repo. Any idea why? |
Member
diff --git a/tests/src/org.eclipse.paho/org.eclipse.paho.client.mqttv3/1.2.5/settings.gradle b/tests/src/org.eclipse.paho/org.eclipse.paho.client.mqttv3/1.2.5/settings.gradle
index 45a98c96..9d961121 100644
--- a/tests/src/org.eclipse.paho/org.eclipse.paho.client.mqttv3/1.2.5/settings.gradle
+++ b/tests/src/org.eclipse.paho/org.eclipse.paho.client.mqttv3/1.2.5/settings.gradle
@@ -1,9 +1,3 @@
-/*
- * Copyright and related rights waived via CC0
- *
- * You should have received a copy of the CC0 legalcode along with this
- * work. If not, see <http://creativecommons.org/publicdomain/zero/1.0/>.
- */
pluginManagement {
def tckPath = Objects.requireNonNullElse(
System.getenv("GVM_TCK_TCKDIR"),These changes are the diff between the old master this branch originates from and the latest master. Rebasing this branch to the latest master should solve the issue. |
jormundur00
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes: #870
This PR resolves an issue where Netty tests were using hard-coded ports, causing
java.net.BindException: Address already in useerrors during our automated CI workflows.To address this, the affected Netty tests have been refactored to use randomly assigned available ports at runtime, preventing port conflicts and improving the reliability of test execution in the CI. This change should be applied to all test versions to ensure future reliability and enable safe automation when introducing new library versions.