Fix liquibase metadata for complete reflection types#775
Merged
vjovanov merged 1 commit intooracle:masterfrom Nov 17, 2025
Merged
Conversation
Member
|
Why doesn't the agent figure that out in the tests? |
vjovanov
approved these changes
Nov 14, 2025
Member
Author
|
The tests that fail because of this issue (https://github.com/oracle/graal/actions/runs/19335605323) don't have an agent run. I believe an agent run would solve these issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds missing registrations to the liquibase metadata, made necessary by the switch to complete reflection types. This new metadata is necessary because
ColumnConfig.getSerializableFields()andAddColumnConfig.getSerializableFields()currently return empty arrays, which is incorrect behavior. This is due toReflectionSerializer.getFieldsperforming a call toClass.getDeclaredMethods()in the background.oracle/graal#12521 fixes Native Image behavior by returning a correct list of fields in this situation for types registered for reflection. Fields returned by
getSerializableFields()are then used to access the field values, and should therefore be registered for reflective access.Code sections where the PR accesses files, network, docker or some external service
none
Checklist before merging