Bump Gradle version to 9.1.0 to allow using GraalVM 25#713
Bump Gradle version to 9.1.0 to allow using GraalVM 25#713kimeta merged 2 commits intooracle:masterfrom
Conversation
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.10-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip |
There was a problem hiding this comment.
Do we need to bump the gradlew script since it is a major version?
There was a problem hiding this comment.
Yes, sorry. We need to change gradlew.bat, gradle-wrapper.jar and gradlew as well.
vjovanov
changed the title
kimeta
force-pushed
the
mm/bump-up-gradle-version
branch
2 times, most recently
from
390e8bf to
1ebeacb
Compare
| } | ||
|
|
||
| private static class HttpServerHandler extends SimpleChannelInboundHandler<Object> { | ||
| private static final class HttpServerHandler extends SimpleChannelInboundHandler<Object> { |
There was a problem hiding this comment.
Why do we have to change the tests for gradle?
There was a problem hiding this comment.
When we upgraded gradle version to 9.1.0, default version of checkstyle upgraded, which caused some of our test code to fail the checkstyleTest task:
> Task :checkstyleTest FAILED
[ant:checkstyle] [ERROR] ...tests/src/io.netty/netty-common/4.1.80.Final/src/test/java/netty/NettyTests.java:246:5: Class HttpServerHandler should be declared as final. [FinalClass]
All changes in the tests are just to fix these failures.
There was a problem hiding this comment.
melix
left a comment
melix
left a comment
There was a problem hiding this comment.
Note that this will require to be more careful when making changes since we're going to compile against newer Gradle APIs, so we need to be extra careful with compatibility with older Gradle releases.
kimeta
force-pushed
the
mm/bump-up-gradle-version
branch
from
1ebeacb to
7c5849c
Compare
| <property name="ignoreConstructorParameter" value="true"/> | ||
| <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/> | ||
| </module> | ||
| <module name="FinalClass"/> |
There was a problem hiding this comment.
We can't have such rules as it will cause issues with AI-generated tests in the future.
3 participants
What does this PR do?
Implements: #709
Upgrade Gradle to 9.1.0 to enable support for GraalVM 25.