Add missing metadata for hibernate-7.0.x annotations without attributes.#702
Merged
fniephaus merged 1 commit intooracle:masterfrom Oct 29, 2025
Merged
Add missing metadata for hibernate-7.0.x annotations without attributes.#702fniephaus merged 1 commit intooracle:masterfrom
fniephaus merged 1 commit intooracle:masterfrom
Conversation
ff36342 to
ffb0044
Compare
…utes. This commit updates the test to captures annotations without attributes that had been missed when collecting metadata in earlier runs.
ffb0044 to
e0100db
Compare
vjovanov
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
hibernate-coremetadata and the test that captures annotations without attributes.Those had been missed when collecting metadata in earlier runs since the loop did not consider the case of empty attributes returned by the
AnnotationDescriptor. In case the annotation does not have any attributes the constructors of the hibernate internal annotation implementing types are now invoked, simulating what hibernate does internally during bootstrap via itsModelHelper.What does this PR do?
Fixes: #700
Code sections where the PR accesses files, network, docker or some external service
Checklist before merging