Fix test containers metadata for --future-defaults#678
Merged
vjovanov merged 2 commits intooracle:masterfrom Sep 19, 2025
Merged
Fix test containers metadata for --future-defaults#678vjovanov merged 2 commits intooracle:masterfrom
vjovanov merged 2 commits intooracle:masterfrom
Conversation
vjovanov
commented
Sep 19, 2025
| ] | ||
| }, | ||
| { | ||
| "name": "getIdentitytoken", |
Member
Author
There was a problem hiding this comment.
These were not needed for me locally, but the CI was requesting them so I added them all (according to 1.19.8 version) to avoid re-running the gates n times.
dnestoro
approved these changes
Sep 19, 2025
Contributor
dnestoro
left a comment
dnestoro
left a comment
There was a problem hiding this comment.
Looks okay, but please remove unnecessary new lines before merging
| "parameterTypes": [] | ||
| "name": "getEmail", | ||
| "parameterTypes": [ | ||
|
|
Contributor
There was a problem hiding this comment.
Just a minor thing: can we get rid of these extra new lines?
| "name": "<init>", | ||
| "parameterTypes": [ | ||
|
|
Contributor
There was a problem hiding this comment.
Looks like all the changes in this file are just empty new lines. If they are not necessary, please revert this change
vjovanov
force-pushed
the
vj/fix-future-defaults-3
branch
from
ac5dc91 to
5807751
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/oracle/graal/actions/runs/17852048838