Skip to content

Make clean task recognize test coordinates#677

Merged
dnestoro merged 1 commit intomasterfrom
dnestoro/make-clean-task-recognize-coordinates
Sep 18, 2025
Merged

Make clean task recognize test coordinates#677
dnestoro merged 1 commit intomasterfrom
dnestoro/make-clean-task-recognize-coordinates

Conversation

@dnestoro
Copy link
Copy Markdown
Contributor

@dnestoro dnestoro commented Sep 18, 2025

What does this PR do?

When running ./gradlew clean test -Pcoordinates=<maven-gav-coordinates>, Gradle won't clean build directory made in a sub-project on the location specified with -Pcoordinates. At the moment user can't force clean sub-project build directory before running test.

In some cases Gradle may think that there are no changes since last run (for example if we just change environment variable) and therefore it won't build a new image. In this case, we would like to force a clean, before running the test.

This PR implements the fix for that.

Note: with this implementation, if we run ./gradlew clean it will perform a clean on all sub-projects. Since ./gradlew test runs all tests from all sub-projects, I would say that this is desirable behavior.

@dnestoro dnestoro requested review from melix and vjovanov September 18, 2025 10:30
@dnestoro dnestoro self-assigned this Sep 18, 2025
@dnestoro dnestoro requested a review from a team as a code owner September 18, 2025 10:30
Copy link
Copy Markdown
Member

@vjovanov vjovanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnestoro dnestoro merged commit 12d0255 into master Sep 18, 2025
249 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants