Skip to content

Add skills directory with fix-missing-reachability-metadata skill#1056

Merged
kimeta merged 2 commits intomasterfrom
mm/add-fix-missing-metadata-ai-workflow
Mar 10, 2026
Merged

Add skills directory with fix-missing-reachability-metadata skill#1056
kimeta merged 2 commits intomasterfrom
mm/add-fix-missing-metadata-ai-workflow

Conversation

@kimeta
Copy link
Copy Markdown
Collaborator

@kimeta kimeta commented Mar 9, 2026

What does this PR do?

Fixes: #1055

In this PR we introduce a skills/ directory to house agent skills and workflows for this repository.
It adds the fix-missing-reachability-metadata skill, which automates the process of fixing missing metadata entries by iteratively running tests, extracting missing entries from error output, and adding them to reachability-metadata.json until all tests pass.

@kimeta kimeta requested a review from jormundur00 March 9, 2026 17:03
@kimeta kimeta requested a review from vjovanov as a code owner March 9, 2026 17:03
- Keep valid JSON and avoid duplicating an existing equivalent entry. If the type already exists but a method or field is missing, add only that method or field.
4. Add the missing `condition` field:
- Infer it from the error stack trace.
- Set the `condition` field to `{ "typeReached": "<class>" }`, where `<class>` is the first stack trace class whose package shares the leading package namespace with the missing type.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would convert "missing type" to the package of the tested library.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree, we have redundancy in the 4th step.

Run a reproduce-fix-verify loop for missing metadata errors. Keep running the target test until it passes with no new missing metadata entries.

- Library coordinates should be provided in the prompt in the format `group:artifact:version`. If you are not sure what the coordinates are, ask the user.
- Target metadata directory under `metadata/` where updates should be written.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Not sure if being more precise here, with specifying metadata/<group>/<artifact>/<version>, might have any benefit here? The skill should be used for fixing already existing metadata, so we are sure that metadata/<group>/<artifact>/<version> always exists I believe.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, no need for this. Especially having similar thing in the second step.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just consider updating the first line in step 3 then to follow the actual structure, as it's always the same (metadata/<group>/<artifact>/<version>/reachability-metadata.json).

@kimeta kimeta force-pushed the mm/add-fix-missing-metadata-ai-workflow branch from 5914762 to 256b655 Compare March 10, 2026 15:03
@kimeta kimeta force-pushed the mm/add-fix-missing-metadata-ai-workflow branch from bcf2374 to 719c89d Compare March 10, 2026 15:07
@kimeta kimeta merged commit 7a69313 into master Mar 10, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Introduce an agent skill for automating the fixing of missing metadata entries

3 participants