Add skills directory with fix-missing-reachability-metadata skill#1056
Add skills directory with fix-missing-reachability-metadata skill#1056
Conversation
| - Keep valid JSON and avoid duplicating an existing equivalent entry. If the type already exists but a method or field is missing, add only that method or field. | ||
| 4. Add the missing `condition` field: | ||
| - Infer it from the error stack trace. | ||
| - Set the `condition` field to `{ "typeReached": "<class>" }`, where `<class>` is the first stack trace class whose package shares the leading package namespace with the missing type. |
There was a problem hiding this comment.
I would convert "missing type" to the package of the tested library.
There was a problem hiding this comment.
Yes I agree, we have redundancy in the 4th step.
| Run a reproduce-fix-verify loop for missing metadata errors. Keep running the target test until it passes with no new missing metadata entries. | ||
|
|
||
| - Library coordinates should be provided in the prompt in the format `group:artifact:version`. If you are not sure what the coordinates are, ask the user. | ||
| - Target metadata directory under `metadata/` where updates should be written. |
There was a problem hiding this comment.
Nit: Not sure if being more precise here, with specifying metadata/<group>/<artifact>/<version>, might have any benefit here? The skill should be used for fixing already existing metadata, so we are sure that metadata/<group>/<artifact>/<version> always exists I believe.
There was a problem hiding this comment.
Agreed, no need for this. Especially having similar thing in the second step.
There was a problem hiding this comment.
I'd just consider updating the first line in step 3 then to follow the actual structure, as it's always the same (metadata/<group>/<artifact>/<version>/reachability-metadata.json).
5914762 to
256b655
Compare
bcf2374 to
719c89d
Compare
What does this PR do?
Fixes: #1055
In this PR we introduce a
skills/directory to house agent skills and workflows for this repository.It adds the
fix-missing-reachability-metadataskill, which automates the process of fixing missing metadata entries by iteratively running tests, extracting missing entries from error output, and adding them toreachability-metadata.jsonuntil all tests pass.