Fix GPSampler crash when torch default device is CUDA#6418
Merged
kAIto47802 merged 1 commit intooptuna:masterfrom Jan 23, 2026
Merged
Fix GPSampler crash when torch default device is CUDA#6418kAIto47802 merged 1 commit intooptuna:masterfrom
kAIto47802 merged 1 commit intooptuna:masterfrom
Conversation
Member
|
@y0z @kAIto47802 Could you review this PR? |
kAIto47802
approved these changes
Jan 23, 2026
Collaborator
kAIto47802
left a comment
There was a problem hiding this comment.
Thank you for the PR. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix GPSampler crash when
torch.set_default_device("cuda")is set globally.When users set
torch.set_default_device("cuda"), GPSampler would crash because torch tensors created internally would be placed on CUDA while numpy arrays remain on CPU, causing conversion errors like:TypeError: can't convert cuda:0 device type tensor to numpy. Use Tensor.cpu() to copy the tensor to host memory first.Changes
sample_relativecomputation in atorch.device("cpu")context manager to force all tensor operations to use CPU_sample_relative_implfor cleaner separationTest plan
test_gpsampler_with_cuda_default_deviceFixes #6113
cc @kAIto47802 (who suggested this approach in the issue comments)