Fix irradiance autodiff indexing#667
Merged
manuelFragata merged 1 commit intoJul 13, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
Thanks for another solid PR, @ahfoysal. All looks good from my end! @manuelFragata - as this is related to your irradiance analysis, can I ask you to quickly review and approve? Thanks, |
manuelFragata
approved these changes
Jul 13, 2026
manuelFragata
left a comment
manuelFragata
left a comment
Collaborator
There was a problem hiding this comment.
hi there @ahfoysal ,
thank you for fixing this.
makes sense and looks good. merging now.
best,
manuel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #408.
Swaps the differentiable irradiance accumulation to keep the same
(x, y)map layout as the regular path, and adds a regression for a non-square detector grid.Tests:
PYTHONPATH=/tmp/optiland-vtk-stub .venv/bin/python -m pytest -q tests/test_analysis.py::TestIncoherentIrradiance.venv/bin/ruff check optiland/analysis/irradiance.py.venv/bin/ruff format --check optiland/analysis/irradiance.pyuv build