Fix curvature solve on plane surfaces#660
Merged
HarrisonKramer merged 1 commit intoJul 6, 2026
Merged
Conversation
ahfoysal
force-pushed
the
fix-curvature-solve-plane
branch
from
July 5, 2026 19:16
d269148 to
8e3308d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
HarrisonKramer
approved these changes
Jul 6, 2026
Collaborator
|
Hi @ahfoysal, Thank you very much for fixing this! Merging now. We'd love to see more contributions from you. For future work, please leave a comment on the issue you'd like to tackle so we can avoid duplicated effort. Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #659.
Curvature solves now set radius through the optic updater, so planar surfaces become standard surfaces when a finite curvature is solved.
Tested: