Activate RET lint rules#9297
Merged
ogenstad merged 9 commits intoMay 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Enable all the disabled RET rules and fixed all the issues.
Closes #2192
What changed
pyproject.toml. So, all the RET related checks are done withruff check.Checklist
uv run towncrier create ...)Summary by cubic
Activates RET return rules in
ruffand resolves RET504 violations by returning values directly across the codebase. No behavior changes expected; adds a clear error whenget_path_valuereceives an unsupported schema path. Aligns with #2192.pyproject.toml;ruff checknow enforces them.ValueErrorfor unsupported schema paths in nodeget_path_value.Written for commit 16f2659. Summary will update on new commits. Review in cubic