fix diff calculation for aware attributes on agnostic schema#9222
Merged
Conversation
github-actions
Bot
added
the
group/backend
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 7 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. This is a targeted bug fix for diff calculation on AGNOSTIC nodes with AWARE attributes, with comprehensive tests covering both diff and merge scenarios, and the logic changes are isolated to query and model path handling without affecting broader system or production critical paths.
ajtmccarty
changed the title
ogenstad
approved these changes
May 12, 2026
polmichel
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9221
Diff calculation was improperly excluding updates on aware attributes of agnostic schemas.
Updates are a few small changes to the diff calculation queries to properly capture a property edge (
HAS_VALUE,IS_PROTECTED,HAS_OWNER,HAS_SOURCE) on a user branch or the default branch when it is under an edge on the global branch.Adds and updates tests to ensure these edges are captured correctly