MAC Address values format update#9134
Merged
polmichel merged 0 commit intoMay 6, 2026
Merged
Conversation
github-actions
Bot
added
type/documentation
polmichel
changed the title
4 tasks
ajtmccarty
reviewed
May 5, 2026
Contributor
There was a problem hiding this comment.
can migrations 70 and 71 be somewhat reordered so that we first update the MAC address attribute values and then update the HFID/display labels using those attributes?
it feels confusing to update IP/MAC HFID and display labels, then update MAC attributes, then update MAC HFID/display labels again
Contributor
Author
There was a problem hiding this comment.
That sounds smart I have not thought about that. Will do
polmichel
force-pushed
the
pmi-20260504-mac-address-values
branch
from
7b95720 to
0ce11ce
Compare
polmichel
merged commit 0ce11ce
into
ai-bug-pipeline-8896-iphost-hfid-consistency
1 of 2 checks passed
polmichel
force-pushed
the
ai-bug-pipeline-8896-iphost-hfid-consistency
branch
from
8f7a28a to
ae529a1
Compare
Contributor
Author
|
This has not really been merged, I have just met the definition of GH "merged" status while trying to invert the migration (a fortiori branches) order. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MAC address values are standardized to the following form: 01-23-45-67-89-AB.
Expected standardized form is 01:23:45:67:89:AB.
Closes #9015 and IFC-2494
What
This PR updates the standardization method against MAC address values, and add a migration to update any existing MAC address attributes or existing display labels/HFID that would reference such attribute.
Additional information
This is built on top of the following PR https://github.com/opsmill/infrahub/pull/8904/commits.