Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

queries parameter validation #63

Closed
camrossi opened this issue Jun 25, 2024 · 0 comments
Closed

queries parameter validation #63

camrossi opened this issue Jun 25, 2024 · 0 comments

Comments

@camrossi
Copy link
Contributor

aci-exporter allows the user to limit which queries to execute by passing a "queries" parameter with a comma separated list of queries.

For example: queries=node_bgp_peers,node_interface_info
If Prometheus is accessing aci-exporter and the scraping config is not correct is possible to send a list that contains spaces, new lines etc...
aci-exporter does not do any validation on this field and will just silently fail.

It should validate the queries and return an error if the format is not correct.
thenodon added a commit that referenced this issue Jul 5, 2024
@thenodon
fix: issue #63 - queries parameter validation. Add trim function to r…
1dfc5d3 
…emove spaces, tab and newline from the queries string.
@thenodon thenodon closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thenodon @camrossi