Repository navigation
fix(upstream): Sprint 2 — #331 taskkill MSYS + #333 adversarial focus text + 6건 plan (Codex audit + R1) - #8
Merged
Conversation
adversarial-review focus text leak fix + 6건 plan doc openai#331: terminateProcessTree(win32)에서 taskkill을 cmd.exe /d /s /c 경유로 변경해 Git Bash(MSYS)의 /PID → C:/Program Files/Git/PID path 오역을 방지. tests/process.test.mjs assertion도 cmd.exe wrapping에 맞게 업데이트. openai#333: handleReviewCommand의 parseCommandInput을 새 parseReviewArgv로 교체. normalizeArgv+splitRawArgumentString이 단일 raw string을 재토큰화할 때 focus text 안의 --FLAG VALUE substring이 실제 CLI option으로 소비되던 문제를 수정. lib/args.mjs에 parseReviewArgv 추가 (review 계열 전용, known option 파싱 후 첫 unknown/positional 이후를 focus text로 처리). docs/exploration/2026-05-28-upstream-high-port-plan.md: 나머지 6건(openai#350 openai#349 openai#345 openai#336 openai#330 openai#295) M/L effort plan 문서화. 각 issue별 위치 후보, effort, 우선순위, fix 방향 포함.
…g) + LOW (plan openai#349 wording) 적용
… cause 명시, commit 누락 보정)
tgkim-openerd
added a commit
that referenced
this pull request
May 28, 2026
…ne + telemetry UX + Windows fixes (#10) ## Version bump 2.1.0 → 2.2.0 (semver minor — additive only, BREAKING 없음) - package.json / package-lock.json / plugins/opnd-codex/.claude-plugin/plugin.json / .claude-plugin/marketplace.json 4 file version sync (scripts/bump-version.mjs 2.2.0) ## CHANGELOG release entry — 2.2.0 (2026-05-28) 본 release 의 main commits (9 PR squash): - #1 daily-evolve pipeline Phase 0~6 + 1.5a + budget - #3 /analyze Recommendations + /doc-sync + PII redact - #4 broker false-negative 해소 (BROKER_BUSY_RPC_CODE + timeout 분기) - #5 Phase A telemetry UX + setup advisory + verified-no-change - #6 Phase B suminerProxy eval + upstream classification - #7 Sprint 1 upstream comment body 8건 - #8 Sprint 2 openai#331 + openai#333 fix + 6 plan - #9 Sprint 3 suminerProxy cherry-pick plan ## semver minor 정합 모두 additive (BREAKING 없음): - 신규 daily-evolve pipeline (별도 commands/skills, 기존 영역 안 건드림) - 신규 HEALTH_STATUS.TRANSIENT enum (existing 5 enum 보존) - 신규 parseReviewArgv() (기존 parseArgs/parseCommandInput 보존) - 신규 SELF_FORKS Set (fork-research 의 fork list filter — false-positive 제거만) - 신규 inspectPluginHomeFreshness() + pluginHomeAdvisory field (additive) - 신규 isUsageLimitError / annotateUsageLimitError (별도 helper) - 기존 isStaleAuthCacheError pattern 확장 (backward compatible) - broker busy / timeout 분기 추가 (catch fallback 보존) - Windows process.mjs cmd.exe 래핑 (behavior change 가능성, e2e 검증 미완 — fork-cover 표기) ## marketplace install 즉시 가능 본 commit + 후속 push + main merge + tag v2.2.0 + gh release 후: ```bash /plugin marketplace add opnd-io/opnd-codex-plugin /plugin install opnd-codex@opnd-codex-plugin /reload-plugins /opnd-codex:setup ``` marketplace.json source = ./plugins/opnd-codex (main branch HEAD) → 사용자 install 시 v2.2.0 모든 변경 즉시 포함. ## 다음 sprint backlog (Unreleased) - suminerProxy NDJSON event stream foundation cherry-pick (Phase 1, 3-4d) - upstream HIGH port 6건 (openai#330 openai#345 openai#350 openai#349 openai#336 openai#295) - quality-review-agent frontmatter description "3 영역 → 6 영역" (classifier 차단, 사용자 인가 후)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sprint 2 — upstream HIGH port 시작
Daily-evolve digest 의 upstream-issue HIGH 8건 (openai#350 openai#349 openai#345 openai#336 openai#333 openai#331 openai#330 openai#295) 중 trivial 2건 실제 fix + 6건 plan doc.
적용된 fix (2건)
openai#331 — codex-companion cancel taskkill MSYS path fix
위치:
plugins/opnd-codex/scripts/lib/process.mjsL168terminateProcessTreeWindows 분기Fix:
runCommandImpl("taskkill", ["/PID", ...])→runCommandImpl("cmd.exe", ["/d", "/s", "/c", "taskkill", "/PID", ...])MSYS/Git Bash 가
/PID같은 single-slash 토큰을 filesystem path 로 변환 → cmd.exe 경유로 MSYS path translator 경계 밖에서 taskkill 실행./T /Fprocess tree semantics 유지.openai#333 — adversarial-review focus text re-tokenization leak
위치:
plugins/opnd-codex/scripts/lib/args.mjs—parseReviewArgv()신규 (+95 lines)plugins/opnd-codex/scripts/codex-companion.mjsL1536handleReviewCommand의 parseCommandInput → parseReviewArgv 교체Root cause: Claude Code 가
/opnd-codex:adversarial-review $ARGUMENTS를 single raw string 전달 →normalizeArgv가splitRawArgumentString으로 재토큰화 → focus text 안의--base main등이 실제 CLI option 으로 소비.Fix 구조: known options 만 greedy 파싱 후 첫 unknown token 부터 모두
focusTokens로 분리. 전역parseArgs/parseCommandInput미변경 — task/agent/pair 서브커맨드 영향 없음.Plan doc (6건 — 다음 sprint 위임)
docs/exploration/2026-05-28-upstream-high-port-plan.md(+140 lines):Codex pair review trace
R2 skip 사유 + Claude self-verify
R2 Codex job 이 process die — 재호출 cost vs value tradeoff. R1 fix 가 cosmetic wiring (valueOptions/booleanOptions array 에 2 항목 추가 + plan wording 1줄) — 회귀 risk 매우 낮음 (Section F "Document Count Consistency" lesson 의 cosmetic loop 회피).
Claude self-verify:
grep "effort\|fast" codex-companion.mjs | grep "Options"→ 양쪽 모두 valueOptions/booleanOptions 에 포함 확인node --test tests/process.test.mjs tests/commands.test.mjs→ 15/15 pass (audit agent + R1 audit 자체 self-test)skip_reason: codex_session_drift(Codex job process 도 die — session 재시작 cost).Commit history (squash 시 1 commit)
검증
node --test tests/process.test.mjs: 5/5 passnode --test tests/commands.test.mjs: 10/10 passnode --check모든 변경 .mjs 통과미검증 영역 (실 환경 e2e 필요)
변경 파일 (5 files / +247 -6)
plugins/opnd-codex/scripts/lib/process.mjs(+4 -1)plugins/opnd-codex/scripts/lib/args.mjs(+95)plugins/opnd-codex/scripts/codex-companion.mjs(+8/-2)tests/process.test.mjs(+5/-1)docs/exploration/2026-05-28-upstream-high-port-plan.md(+140)merge 전략
Squash merge 권장 — 3 commits → 1 commit `fix(upstream): Sprint 2` 로 main history clean.