cherry pick: Version and release documentation (#531) #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* .gitignore,Makefile: added 'build' Makefile target to build a binary within project context (in 'build' dir), and .gitignore clause * doc/release-versioning.md: rough draft of release and versioning semantics and mechanics * Makefile: add mutiple build targets and reformat 'all' make target * release.sh: tag and build release with a few pre-build checks * Makefile: added signature make targets to run under release target * doc/release-versioning.md: revised release process such that 'release.sh' automates everything from building multi-arch to signing * Makefile: add '--tags' flag when retrieving version so the current tag is retrieved regardless of signature * Makefile: ensure git and gpg are configured to have the same signing key * doc/release-versioning.md: document supported k8s versions, architectures, and platforms in their own section * release.sh,Makefile,pkg/generator/templates.go: check versions before tagging on release
openshift-ci-robot
added
the
size/L
hasbro17
reviewed
Oct 11, 2018
release.sh
Outdated
| TOML_TMPL_FILE="pkg/generator/templates.go" | ||
| CURR_VER_VER_FILE="$(sed -nr 's/Version = "(.+)"/\1/p' "$VER_FILE" | tr -d '\s\t\n')" | ||
| CURR_VER_TMPL_FILE="$(sed -nr 's/.*".*v(.+)".*#osdk_version_annotation/v\1/p' "$TOML_TMPL_FILE" | tr -d '\s\t\n')" | ||
| if [ "$CURR_VER" != "$CURR_VER_VER_FILE" ] \ |
Contributor
There was a problem hiding this comment.
This should be comparing the desired version with verison.go. if [ "$VER" != "$CURR_VER_VER_FILE" ]
Say I'm trying to cut the tag for v0.0.7 and I've updated version.go and Gopkg.toml to v0.0.7.
But before this script can actually cut the tag, my current tag would be v0.0.6.
The current tag is something the script would update. The check should be to make sure version.go and Gopkg.toml are already updated to use the desired $VER.
hasbro17
reviewed
Oct 11, 2018
estroz
force-pushed
the
refactor/cherry-pick-versioning
branch
from
446ddea to
32f9916
Compare
AlexNPavel
approved these changes
Oct 12, 2018
Contributor
AlexNPavel
left a comment
AlexNPavel
left a comment
There was a problem hiding this comment.
I think this is ready to merge now. The changes made here should also be backported to the master branch before doing the v0.0.7 release to make sure we can do a proper release on master before rebasing this branch over master.
shawn-hurley
pushed a commit
to shawn-hurley/operator-sdk
that referenced
this pull request
Oct 12, 2018
… (operator-framework#604) * .gitignore,Makefile: added 'build' Makefile target to build a binary within project context (in 'build' dir), and .gitignore clause * Makefile: add mutiple build targets and reformat 'all' make target * Makefile: added signature make targets to run under release target * Makefile: ensure git and gpg are configured to have the same signing key * doc/release-versioning.md: document supported k8s versions, architectures, and platforms in their own section * release.sh,Makefile,pkg/generator/templates.go: check versions before tagging on release
shawn-hurley
pushed a commit
that referenced
this pull request
Oct 16, 2018
* .gitignore,Makefile: added 'build' Makefile target to build a binary within project context (in 'build' dir), and .gitignore clause * Makefile: add mutiple build targets and reformat 'all' make target * Makefile: added signature make targets to run under release target * Makefile: ensure git and gpg are configured to have the same signing key * doc/release-versioning.md: document supported k8s versions, architectures, and platforms in their own section * release.sh,Makefile,pkg/generator/templates.go: check versions before tagging on release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has useful annotations and makes the build workflow a bit easier.