api: framework api to register user sync() func #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongchaodeng
changed the title
xiang90
reviewed
Feb 8, 2018
| */ | ||
|
|
||
| // SyncCallback defines user business logic for when resource events are triggered. | ||
| type SyncCallback struct { |
There was a problem hiding this comment.
as we discussed offline, sync should not be per resource based.
Contributor
Author
There was a problem hiding this comment.
Right.
What's your suggestion for users to define the resources they "care about"?
Maybe we can change RegisterSync(SyncBallback, ResourceTypesToWatch...)?
There was a problem hiding this comment.
We should generate a Sync function stub for users to fill in. Users do not need to register that func with us at all. User only need to tell the SDK what resources that are interested in. Probably call sdk.Watch(resourceX).
Contributor
Author
|
@hasbro17 to take over the PR. |
Contributor
Author
|
Closing this due to staleness |
shawn-hurley
pushed a commit
to shawn-hurley/operator-sdk
that referenced
this pull request
Apr 23, 2019
…ove-proxy-unit-test remove proxy test because it needs a cluster.
2 tasks
VenkatRamaraju
referenced
this pull request
in VenkatRamaraju/operator-sdk
Mar 17, 2022
…added bundle image in it and serve contents. (#6) Signed-off-by: rashmigottipati <[email protected]>
VenkatRamaraju
referenced
this pull request
in VenkatRamaraju/operator-sdk
Mar 22, 2022
…added bundle image in it and serve contents. (#6) Signed-off-by: rashmigottipati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.