Skip to content

Release signing process #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
estroz merged 1 commit into from
Nov 2, 2018
Merged

Release signing process #588

estroz merged 1 commit into from
Nov 2, 2018

Conversation

@estroz
Copy link
Member

@estroz estroz commented Oct 10, 2018 •
edited
Loading

All binary releases should be signed using a single, well-known PGP key or any of the maintainers'.
/cc @AlexNPavel @hasbro17

@estroz estroz added kind/feature Categorizes issue or PR as related to a new feature. needs discussion do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. documentation labels Oct 10, 2018
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 10, 2018
@estroz estroz mentioned this pull request Oct 10, 2018
Merged
AlexNPavel
AlexNPavel reviewed Oct 10, 2018
View reviewed changes
@estroz estroz force-pushed the release-signing-process branch 4 times, most recently from d4a3b0b to 746197f Compare October 22, 2018 18:38
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2018
@estroz estroz closed this Oct 22, 2018
@estroz estroz reopened this Oct 22, 2018
@estroz
doc/release-versioning.md: document signing process for binaries
900c162 
Makefile: add release targets to 'release' target
@estroz estroz force-pushed the release-signing-process branch from 746197f to 900c162 Compare November 2, 2018 00:30
@estroz estroz changed the title [WIP] Release signing process Release signing process Nov 2, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2018
hasbro17
hasbro17 approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz estroz merged commit ee6eee6 into operator-framework:master Nov 2, 2018
@estroz estroz deleted the release-signing-process branch November 2, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spahl spahl Awaiting requested review from spahl

@robszumski robszumski Awaiting requested review from robszumski

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

@lilic lilic Awaiting requested review from lilic

2 more reviewers

@AlexNPavel AlexNPavel AlexNPavel left review comments

@hasbro17 hasbro17 hasbro17 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/feature Categorizes issue or PR as related to a new feature. needs discussion size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@estroz @AlexNPavel @hasbro17 @openshift-ci-robot