Skip to content

Conversation

@estroz
Copy link
Member

@estroz estroz commented Feb 19, 2021

Description of the change:

  • images/ansible-operator/base.Dockerfile: Dockerfile for the ansible-operator-base image
  • .github/workflows/deploy-manual.yml: start workflows manually, namely the ansible-operator-base image deployment job

Motivation for the change: the ansible-operator image takes awhile to build, so it would be nice to build a base image containing the long-running dependency installation steps every so often, ex. when dependencies are updated.

/area dependency

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci-robot openshift-ci-robot added the area/dependency Issues or PRs related to dependency changes label Feb 19, 2021
@estroz
Copy link
Member Author

estroz commented Feb 19, 2021

/cc @jmrodri @theishshah

@estroz
Copy link
Member Author

estroz commented Feb 19, 2021

The default tag would look like

quay.io/operator-framework/ansible-operator-base:v1.4.0-24-g0c75f7af1801373a3c85e3fb728dd2dccfd6a851

Which would then be pinned in images/ansible-operator/Dockerfile like

# Builder
FROM --platform=$BUILDPLATFORM golang:1.15 as builder
ARG TARGETARCH
...
RUN GOOS=linux GOARCH=$TARGETARCH make build/ansible-operator
# New base image
FROM quay.io/operator-framework/ansible-operator-base:v1.4.0-24-g0c75f7af1801373a3c85e3fb728dd2dccfd6a851

COPY --from=builder /workspace/build/ansible-operator /usr/local/bin/ansible-operator

CMD ["/usr/local/bin/ansible-operator", "run", "--watches-file=./watches.yaml"]

estroz added 2 commits March 3, 2021 12:21
ansible-operator-base image

.github/workflows/deploy-manual.yml: start workflows manually,
namely the ansible-operator-base image deployment job

Signed-off-by: Eric Stroczynski <[email protected]>
Signed-off-by: Eric Stroczynski <[email protected]>
@estroz
Copy link
Member Author

estroz commented Mar 3, 2021

/retest

@estroz estroz temporarily deployed to deploy March 3, 2021 20:29 Inactive
@estroz estroz temporarily deployed to deploy March 3, 2021 20:29 Inactive
@estroz estroz temporarily deployed to deploy March 3, 2021 20:29 Inactive
@estroz estroz temporarily deployed to deploy March 3, 2021 20:29 Inactive
@estroz estroz temporarily deployed to deploy March 3, 2021 20:29 Inactive
@estroz estroz temporarily deployed to deploy March 3, 2021 20:29 Inactive
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that we are only adding this one because it is required for we speeding the process to build the ansible image.

It is not required for helm because the only ansible one has many deps.
I am ok with 👍

@estroz estroz merged commit 9c37182 into operator-framework:master Mar 4, 2021
@estroz estroz deleted the feature/ansible-base-image branch March 4, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Issues or PRs related to dependency changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants