Skip to content

[v1.3.x] images/ansible-operator/Dockerfile: pin cryptography python package #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
estroz merged 1 commit into from
Feb 11, 2021
Merged

[v1.3.x] images/ansible-operator/Dockerfile: pin cryptography python package #4510

estroz merged 1 commit into from
Feb 11, 2021

Conversation

@estroz
Copy link
Member

@estroz estroz commented Feb 11, 2021 •
edited
Loading

Description of the change:

  • images/ansible-operator/Dockerfile: pin cryptography python package t…o version that does not require the rust compiler to set up

Motivation for the change: ansible-operator image build is broken:

$ git checkout v1.3.x
$ make image/ansible-operator
...
Collecting cryptography (from ansible==2.9.15)
  Downloading https://files.pythonhosted.org/packages/27/5a/007acee0243186123a55423d49cbb5c15cb02d76dd1b6a27659a894b13a2/cryptography-3.4.4.tar.gz (545kB)
    Complete output from command python setup.py egg_info:
    
	...
    
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-7t2f19qr/cryptography/setup.py", line 14, in <module>
        from setuptools_rust import RustExtension
    ModuleNotFoundError: No module named 'setuptools_rust'

Users won't see a chance here because v1.3.1 was built with cryptography v3.3.1, which this PR pins to.

Signed-off-by: Eric Stroczynski [email protected]

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@estroz
images/ansible-operator/Dockerfile: pin cryptography python package t…
87a8bfd 
…o version that does not require the rust compiler to set up

Signed-off-by: Eric Stroczynski <[email protected]>
@estroz
Copy link
Member Author

estroz commented Feb 11, 2021

/cc @jmrodri @asmacdo

@estroz estroz mentioned this pull request Feb 11, 2021
Merged
@estroz
Copy link
Member Author

estroz commented Feb 11, 2021

/retest

rashmigottipati
rashmigottipati approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2021
@estroz estroz merged commit 0ec4b70 into operator-framework:v1.3.x Feb 11, 2021
@estroz estroz deleted the chore/pin-cryptography-v1.3.x branch February 11, 2021 22:46
@rashmigottipati
Copy link
Member

rashmigottipati commented Feb 11, 2021

Reproduced the issue with v1.3.x and verified that this fix works!

@estroz
Copy link
Member Author

estroz commented Feb 13, 2021

This is happening on non-amd64/arm64 machines in v1.4.x now.

/cherry-pick v1.4.x

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 13, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 13, 2021

@estroz: new pull request created: #4522

Details

In response to this:

This is happening on non-amd64/arm64 machines in v1.4.x now.

/cherry-pick v1.4.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz
Copy link
Member Author

estroz commented Feb 13, 2021

/cherry-pick master

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 13, 2021

@estroz: new pull request created: #4523

Details

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 13, 2021
Closed
This was referenced Feb 13, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

@marc-obrien marc-obrien Awaiting requested review from marc-obrien

@asmacdo asmacdo Awaiting requested review from asmacdo

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees

@rashmigottipati rashmigottipati

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@estroz @rashmigottipati @openshift-cherrypick-robot @openshift-ci-robot