generate: fix multiple Go file type parsing bug #4507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
kind/bug
Member
Author
untyped and Typ-typed *ast.Object's that underly an *ast.Ident, such that types in other files are found properly Signed-off-by: Eric Stroczynski <[email protected]>
jmrodri
approved these changes
Feb 11, 2021
Member
jmrodri
left a comment
jmrodri
left a comment
There was a problem hiding this comment.
/lgtm
the tests helped me understand what was going on. +1
Member
Author
|
/cherry-pick v1.3.x |
|
@estroz: new pull request created: #4508 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
Author
|
/cherry-pick v1.4.x |
|
@estroz: new pull request created: #4509 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: see #3744
Closes #3744
/kind bug
Signed-off-by: Eric Stroczynski [email protected]
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs