Pipenv dependency management #4477
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note that the commit list is rather long simply because I rebased and merged from upstream, but the Python version pinning and Docker image pinning were already merged. |
reinvantveer
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
reinvantveer
force-pushed
the
pipenv_dependency_management
branch
from
984be31 to
ff9f845
Compare
openshift-ci-robot
added
needs-rebase
reinvantveer
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
Yay, passed! |
estroz
reviewed
Feb 4, 2021
Member
|
@reinvantveer looks like you need to rebase onto the latest master. |
…erator-framework#4407) Signed-off-by: Eric Stroczynski <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
…-framework#4431) Signed-off-by: Rein van 't Veer <[email protected]>
… a previous operator version doesn't exist (operator-framework#4448) * `run bundle-upgrade` should handle error gracefully when a previous operator version doesn't exist Signed-off-by: rashmigottipati <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
…erator-framework#4449) Bumped to operator-framework/api. Signed-off-by: jesus m. rodriguez <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
…g release (operator-framework#3431) Signed-off-by: Rein van 't Veer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]>
…erator-framework#4462) Signed-off-by: Eric Stroczynski <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
…projects (operator-framework#4419) Signed-off-by: Rein van 't Veer <[email protected]>
…ework#4445) internal/generatel/clusterserviceversion/bases/definitions: make the owned CRD generator package- and type-aware so multiple packages containing the same type names can be used. Signed-off-by: Eric Stroczynski <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
* upgrade Python to v 3.8 * add change notes * add python to installation guide Signed-off-by: reinvantveer <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
This commit modifies the suggested format for finalizers from <finalizer-name>.<qualified-group> to <qualified-group>/<finalizer-name>, which is the recommended format in k8s docs. This change is not breaking because technically any name format is allowed Signed-off-by: Eric Stroczynski <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
…-framework#4471) * Fixed invalid object names generated for long package names * TrimDNS1123Label would trim strings but end up creating invalid DNS1123 strings. * FormatOperatorNameDNS1123 would return strings that were invalid if they begin or end with non-alphanumeric or hyphens. * Handle capitals and use more efficient trim mechanism * React to new expectation. Fixes operator-framework#4470 Signed-off-by: jesus m. rodriguez <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]>
…iption Signed-off-by: Rein van 't Veer <[email protected]>
…ub-dependencies and resolve potential conflicts Signed-off-by: Rein van 't Veer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
…iption Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
…iption Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
…iption Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
…iption Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
… vulnerability checks in base site-packages Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
…iption Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
…iption Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
…iption Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
…iption Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
… vulnerability checks in base site-packages Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
…iption Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
…iption Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
…to pipenv_dependency_management # Conflicts: # images/ansible-operator/Dockerfile
Contributor
Author
@estroz I'm in a spot of trouble here. I tried rebasing using It appears I'm stuck in some kind of loop with failing rebases, merges, missing signoffs, forced pushes. I have no idea on how to get out of this. |
Contributor
Author
|
I'll try in a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Use Pipenv - the Python packaging authority recommended way - as a dependency resolution managemente system and vulnerability checker to install Python dependencies.
This PR is part of #4237 to work towards a more user-friendly way of doing reproducible local builds
Motivation for the change:
Python package dependency is best managed using a fit-for-purpose package manager that checks for dependency conflicts, separates wanted dependencies from required subdependencies and that is able to check for vulnerabilities. The proposed solution is fully backwards compatible.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs