Fixed invalid object names generated for long package names #4471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
reviewed
Feb 3, 2021
jmrodri
force-pushed
the
issue4470
branch
2 times, most recently
from
eef1a41 to
16149a3
Compare
estroz
suggested changes
Feb 3, 2021
jberkhahn
reviewed
Feb 3, 2021
estroz
reviewed
Feb 3, 2021
Contributor
|
ok |
estroz
reviewed
Feb 3, 2021
* TrimDNS1123Label would trim strings but end up creating invalid DNS1123 strings. * FormatOperatorNameDNS1123 would return strings that were invalid if they begin or end with non-alphanumeric or hyphens. Fixes operator-framework#4470 Signed-off-by: jesus m. rodriguez <[email protected]>
Signed-off-by: jesus m. rodriguez <[email protected]>
Signed-off-by: jesus m. rodriguez <[email protected]>
Member
Author
|
@estroz updated it and rebased things around. |
jmrodri
changed the title
Member
Author
|
/cherry-pick v1.3.x |
|
@jmrodri: new pull request created: #4476 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 4, 2021
…-framework#4471) * Fixed invalid object names generated for long package names * TrimDNS1123Label would trim strings but end up creating invalid DNS1123 strings. * FormatOperatorNameDNS1123 would return strings that were invalid if they begin or end with non-alphanumeric or hyphens. * Handle capitals and use more efficient trim mechanism * React to new expectation. Fixes operator-framework#4470 Signed-off-by: jesus m. rodriguez <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 4, 2021
…-framework#4471) * Fixed invalid object names generated for long package names * TrimDNS1123Label would trim strings but end up creating invalid DNS1123 strings. * FormatOperatorNameDNS1123 would return strings that were invalid if they begin or end with non-alphanumeric or hyphens. * Handle capitals and use more efficient trim mechanism * React to new expectation. Fixes operator-framework#4470 Signed-off-by: jesus m. rodriguez <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…-framework#4471) * Fixed invalid object names generated for long package names * TrimDNS1123Label would trim strings but end up creating invalid DNS1123 strings. * FormatOperatorNameDNS1123 would return strings that were invalid if they begin or end with non-alphanumeric or hyphens. * Handle capitals and use more efficient trim mechanism * React to new expectation. Fixes operator-framework#4470 Signed-off-by: jesus m. rodriguez <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…-framework#4471) * Fixed invalid object names generated for long package names * TrimDNS1123Label would trim strings but end up creating invalid DNS1123 strings. * FormatOperatorNameDNS1123 would return strings that were invalid if they begin or end with non-alphanumeric or hyphens. * Handle capitals and use more efficient trim mechanism * React to new expectation. Fixes operator-framework#4470 Signed-off-by: jesus m. rodriguez <[email protected]> Signed-off-by: reinvantveer <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…-framework#4471) * Fixed invalid object names generated for long package names * TrimDNS1123Label would trim strings but end up creating invalid DNS1123 strings. * FormatOperatorNameDNS1123 would return strings that were invalid if they begin or end with non-alphanumeric or hyphens. * Handle capitals and use more efficient trim mechanism * React to new expectation. Fixes operator-framework#4470 Signed-off-by: jesus m. rodriguez <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strings.
they begin or end with non-alphanumeric or hyphens.
Fixes #4470
Signed-off-by: jesus m. rodriguez [email protected]
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs