run bundle{-upgrade}: validate --mode before running a bundle
#4462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
kind/bug
Member
rashmigottipati
left a comment
rashmigottipati
left a comment
There was a problem hiding this comment.
Validation part looks good to me, but I'm thinking about why we need to have bundle add mode as an optional hidden flag in the case of run bundle-upgrade, in the first place.
For run bundle, we explicitly said we need it. But for upgrade, is there is a good reason to have it as an optional hidden flag?
Member
Author
|
@rashmigottipati good question. I argue that bundle add mode is more important for |
… image Signed-off-by: Eric Stroczynski <[email protected]>
estroz
force-pushed
the
bugfix/validate-add-mode
branch
from
0a90f9e to
7041102
Compare
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 4, 2021
…erator-framework#4462) Signed-off-by: Eric Stroczynski <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 4, 2021
…erator-framework#4462) Signed-off-by: Eric Stroczynski <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…erator-framework#4462) Signed-off-by: Eric Stroczynski <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…erator-framework#4462) Signed-off-by: Eric Stroczynski <[email protected]> Signed-off-by: reinvantveer <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…erator-framework#4462) Signed-off-by: Eric Stroczynski <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: values should be validated before the heavy lifting of these commands occurs (pulling/unpacking a bundle)
/kind bug
Signed-off-by: Eric Stroczynski [email protected]
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs