Bug 1921727: Bundle validate should not fail because of warnings. #4449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/hold needs changelog |
openshift-ci-robot
added
the
do-not-merge/hold
Member
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
jmrodri
requested review from
estroz and
varshaprasad96
and removed request for
fabianvf
Bumped to operator-framework/api. Signed-off-by: jesus m. rodriguez <[email protected]>
Contributor
|
/lgtm |
estroz
pushed a commit
to estroz/operator-sdk
that referenced
this pull request
Feb 1, 2021
…erator-framework#4449) Bumped to operator-framework/api. Signed-off-by: jesus m. rodriguez <[email protected]>
estroz
pushed a commit
that referenced
this pull request
Feb 1, 2021
…ings. (#4449) (#4458) Bumped to operator-framework/api. Signed-off-by: jesus m. rodriguez <[email protected]> Co-authored-by: Jesus Rodriguez <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 4, 2021
…erator-framework#4449) Bumped to operator-framework/api. Signed-off-by: jesus m. rodriguez <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 4, 2021
…erator-framework#4449) Bumped to operator-framework/api. Signed-off-by: jesus m. rodriguez <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…erator-framework#4449) Bumped to operator-framework/api. Signed-off-by: jesus m. rodriguez <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…erator-framework#4449) Bumped to operator-framework/api. Signed-off-by: jesus m. rodriguez <[email protected]> Signed-off-by: reinvantveer <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…erator-framework#4449) Bumped to operator-framework/api. Signed-off-by: jesus m. rodriguez <[email protected]> Signed-off-by: Rein van 't Veer <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Bumped to operator-framework/api.
Motivation for the change:
Bundle validate with optional validators would fail if there was a warning during the validation instead of passing but listing out the warning.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs