fix: (helm) - prevent a possible nil pointer in the helm uninstall #4288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
suggested changes
Dec 7, 2020
Signed-off-by: Mike Ng <[email protected]>
estroz
pushed a commit
to estroz/operator-sdk
that referenced
this pull request
Dec 7, 2020
10 tasks
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…perator-framework#4288) Signed-off-by: Mike Ng <[email protected]> Signed-off-by: reinvantveer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mike Ng [email protected]
Description of the change:
It's possible to run into a nil pointer error during a helm uninstall
Motivation for the change:
Prevent the nil pointer error from happening.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)its not a user-facing changes.
website/content/en/docsno doc updates required.