Fix bug when send multi messages in pulsar sender#277
Merged
shakuzen merged 1 commit intoopenzipkin:masterfrom Feb 13, 2025
Merged
Fix bug when send multi messages in pulsar sender#277shakuzen merged 1 commit intoopenzipkin:masterfrom
shakuzen merged 1 commit intoopenzipkin:masterfrom
Conversation
Contributor
CodePrometheus
commented
Feb 12, 2025
CodePrometheus
commented
- Fix bug when send multi messages in pulsar sender
- Add corresponding test
shakuzen
approved these changes
Feb 12, 2025
Member
shakuzen
left a comment
shakuzen
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. The test shows this works now. I left a comment for consideration about the test but no need to block merging on it.
CodePrometheus
force-pushed
the
fix-sender
branch
from
964a73f to
e15769b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.