Resurrects webflux5-sleuth and removes sleuth brave version pin #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sleuth 3.1.11 was released and that fixed flux eureka discovery as well moved off deprecated functions that made it impossible to update to Brave 6.0.
This does a few things:
depends_onshould work docker/compose#7916Note: Sleuth is still pinned to reporter 2.x as it includes auto-configuration of its own senders which rely on 2.x signatures. However, Brave no longer cares about reporter versions, and this repo is mostly about brave.
While automatically tested now (and yeah I verified in the logs it is), I also manually tested all the eureka-enabled examples and pasted screenshot of best request in 6 below:
armeria (netty) 2.7ms

webflux5-sleuth (netty) 4.1ms

webmvc5-sleuth (servlet) 3.4ms

Nice job as always, armeria (ack it is cheating as armeria has effectively zero abstraction cost :p)