Skip to content

Conversation

@codefromthecrypt
Copy link
Member

@codefromthecrypt codefromthecrypt commented Feb 10, 2024

Sleuth 3.1.11 was released and that fixed flux eureka discovery as well moved off deprecated functions that made it impossible to update to Brave 6.0.

This does a few things:

  • resurrects webflux5-sleuth adding the same eureka configuration as webmvc5-sleuth
  • un-pins the brave version in both sleuth examples (so it now uses Brave 6.0)
  • makes our CI enforce eureka tests, to avoid any future drift breaking any of our examples.
    • we need this to protect the time of our maintainers, due to lack of regularly run integration tests anywhere else.
  • refactors also the kafka tests to reduce duplication, despite Extend service with depends_on should work  docker/compose#7916

Note: Sleuth is still pinned to reporter 2.x as it includes auto-configuration of its own senders which rely on 2.x signatures. However, Brave no longer cares about reporter versions, and this repo is mostly about brave.

While automatically tested now (and yeah I verified in the logs it is), I also manually tested all the eureka-enabled examples and pasted screenshot of best request in 6 below:

armeria (netty) 2.7ms
armeria

webflux5-sleuth (netty) 4.1ms
webflux5-sleuth

webmvc5-sleuth (servlet) 3.4ms
webmvc5-sleuth

Nice job as always, armeria (ack it is cheating as armeria has effectively zero abstraction cost :p)

Sleuth 3.1.11 was released and that fixed flux eureka discovery as well
moved off deprecated functions that made it impossible to update to
Brave 6.0.

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt codefromthecrypt changed the title Resurrects weflux5-sleuth and removes sleuth version pinning Resurrects webflux5-sleuth and removes sleuth brave version pin Feb 10, 2024
@codefromthecrypt codefromthecrypt merged commit 14a408d into master Feb 10, 2024
@codefromthecrypt codefromthecrypt deleted the resurrect-the-flux branch February 10, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants