license: removes copyright year and uses SPDX ID#1433
Merged
codefromthecrypt merged 1 commit intomasterfrom Apr 10, 2024
Merged
license: removes copyright year and uses SPDX ID#1433codefromthecrypt merged 1 commit intomasterfrom
codefromthecrypt merged 1 commit intomasterfrom
Conversation
Signed-off-by: Adrian Cole <[email protected]>
reta
reviewed
Apr 10, 2024
| # Prevent use of implicit GitHub Actions read-only token GITHUB_TOKEN. We don't deploy on | ||
| # the tag MAJOR.MINOR.PATCH event, but we still need to deploy the maven-release-plugin master commit. | ||
| token: ${{ secrets.GH_TOKEN }} | ||
| fetch-depth: 1 # only need the HEAD commit as license check isn't run |
Contributor
There was a problem hiding this comment.
Any reasons for that? (the clone is much faster with depth = 1)
Member
Author
There was a problem hiding this comment.
sure. the comment is wrong after this change (and 1 is the default) https://github.com/actions/checkout?tab=readme-ov-file#usage
reta
approved these changes
Apr 10, 2024
Contributor
reta
left a comment
reta
left a comment
There was a problem hiding this comment.
Huge one but luckily easy for review
codefromthecrypt
added a commit
that referenced
this pull request
Apr 14, 2024
We missed a couple cases in #1433 Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
added a commit
that referenced
this pull request
Apr 14, 2024
We missed a couple cases in #1433 --------- Signed-off-by: Adrian Cole <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
same rationale as openzipkin/zipkin-reporter-java#257