Undeprecates propagation symbols for v6 interop#1396
Conversation
See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <[email protected]>
See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <[email protected]>
This updates to Brave 5.17.1 and dodges an internal type that will not be in Brave 6.0. See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <[email protected]>
This updates to Brave 5.17.1 and dodges an internal type that will not be in Brave 6.0. See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <[email protected]>
This undeprecates B3SinglePropagation and enforces at runtime that `Propagation.Factory#get()` must be implemented. I spot checked all the implementations on GitHub already do. Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
undeprecate
branch
from
d7b7fc7 to
fa43521
Compare
This updates to Brave 5.17.1 and dodges an internal type that will not be in Brave 6.0. See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <[email protected]>
This dodges an internal type that will not be in Brave 6.0. See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <[email protected]>
|
ok I scraped github and raised PRs for all the known implementations of propagation. Most were things I did or copies of stuff @marcingrzejszczak made cc @shakuzen After those projects merge, they will be safe to update into Brave 6 (#1395) |
| * }</pre> | ||
| * | ||
| * @since 5.12 | ||
| * @deprecated As of Brave 5.18, throw an {@link UnsupportedOperationException} in |
There was a problem hiding this comment.
this is internal, but I put a deprecated message on it anyway as many have been using it without shading. The pull requests I mentioned move off it.
|
Also, all PRs I mentioned on this issue are opened to allow editors to write to my branch. Not saying they will, but they can as necessary. |
|
I also released this to maven central as it seems there are a couple copies of brave w3c tracecontext (even if not the same impl as the one I wrote) https://central.sonatype.com/artifact/io.zipkin.contrib.brave-propagation-w3c/brave-propagation-tracecontext/versions https://github.com/openzipkin-contrib/brave-propagation-w3c |
See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <[email protected]>
See openzipkin/brave#1396 about Propagation and Brave 6.0 Signed-off-by: Adrian Cole <[email protected]>
2 participants
This undeprecates B3SinglePropagation and enforces at runtime that
Propagation.Factory#get()must be implemented. I spot checked all the implementations on GitHub already do.