Fix build break in convolution_thunk_internal #22572
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @xla-rotation please take a look. |
allanrenucci
approved these changes
Feb 12, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
Imported from GitHub PR #22572 After this change 8e6b84b, following build error occurred: ``` In file included from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/backends/cpu/runtime/convolution_thunk_internal.h: In lambda function: ./xla/backends/cpu/runtime/convolution_thunk_internal.h:345:71: error: no matching function for call to ‘tsl::CountDownAsyncValueRef<tsl::Chain>::CountDown() const’ 345 | auto on_done = [count_down]() mutable { count_down.CountDown(); }; | ~~~~~~~~~~~~~~~~~~~~^~ In file included from ./xla/backends/cpu/runtime/convolution_thunk_internal.h:26, from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(size_t, const absl::lts_20230802::Status&) [with T = tsl::Chain; size_t = long unsigned int]’ 867 | bool CountDown(size_t count, const absl::Status& status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate expects 2 arguments, 0 provided ./xla/tsl/concurrency/async_value_ref.h:919:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(absl::lts_20230802::Status) [with T = tsl::Chain]’ (near match) 919 | bool CountDown(absl::Status status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:919:8: note: passing ‘const tsl::CountDownAsyncValueRef<tsl::Chain>*’ as ‘this’ argument discards qualifiers ``` Copybara import of the project: -- 69268a6 by Milica Makevic <[email protected]>: Allow modification of captured variable in nested lambda Merging this change closes #22572 FUTURE_COPYBARA_INTEGRATE_REVIEW=#22572 from ROCm:ci_build_fix_250211 69268a6 PiperOrigin-RevId: 725970892
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Feb 13, 2025
Imported from GitHub PR openxla/xla#22572 After this change openxla/xla@8e6b84b, following build error occurred: ``` In file included from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/backends/cpu/runtime/convolution_thunk_internal.h: In lambda function: ./xla/backends/cpu/runtime/convolution_thunk_internal.h:345:71: error: no matching function for call to ‘tsl::CountDownAsyncValueRef<tsl::Chain>::CountDown() const’ 345 | auto on_done = [count_down]() mutable { count_down.CountDown(); }; | ~~~~~~~~~~~~~~~~~~~~^~ In file included from ./xla/backends/cpu/runtime/convolution_thunk_internal.h:26, from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(size_t, const absl::lts_20230802::Status&) [with T = tsl::Chain; size_t = long unsigned int]’ 867 | bool CountDown(size_t count, const absl::Status& status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate expects 2 arguments, 0 provided ./xla/tsl/concurrency/async_value_ref.h:919:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(absl::lts_20230802::Status) [with T = tsl::Chain]’ (near match) 919 | bool CountDown(absl::Status status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:919:8: note: passing ‘const tsl::CountDownAsyncValueRef<tsl::Chain>*’ as ‘this’ argument discards qualifiers ``` Copybara import of the project: -- 69268a699eb07efb65be4e42087f75d504f750a6 by Milica Makevic <[email protected]>: Allow modification of captured variable in nested lambda Merging this change closes #22572 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#22572 from ROCm:ci_build_fix_250211 69268a699eb07efb65be4e42087f75d504f750a6 PiperOrigin-RevId: 725970892
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
Imported from GitHub PR #22572 After this change 8e6b84b, following build error occurred: ``` In file included from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/backends/cpu/runtime/convolution_thunk_internal.h: In lambda function: ./xla/backends/cpu/runtime/convolution_thunk_internal.h:345:71: error: no matching function for call to ‘tsl::CountDownAsyncValueRef<tsl::Chain>::CountDown() const’ 345 | auto on_done = [count_down]() mutable { count_down.CountDown(); }; | ~~~~~~~~~~~~~~~~~~~~^~ In file included from ./xla/backends/cpu/runtime/convolution_thunk_internal.h:26, from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(size_t, const absl::lts_20230802::Status&) [with T = tsl::Chain; size_t = long unsigned int]’ 867 | bool CountDown(size_t count, const absl::Status& status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate expects 2 arguments, 0 provided ./xla/tsl/concurrency/async_value_ref.h:919:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(absl::lts_20230802::Status) [with T = tsl::Chain]’ (near match) 919 | bool CountDown(absl::Status status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:919:8: note: passing ‘const tsl::CountDownAsyncValueRef<tsl::Chain>*’ as ‘this’ argument discards qualifiers ``` Copybara import of the project: -- 69268a6 by Milica Makevic <[email protected]>: Allow modification of captured variable in nested lambda Merging this change closes #22572 FUTURE_COPYBARA_INTEGRATE_REVIEW=#22572 from ROCm:ci_build_fix_250211 69268a6 PiperOrigin-RevId: 725970892
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
Imported from GitHub PR #22572 After this change 8e6b84b, following build error occurred: ``` In file included from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/backends/cpu/runtime/convolution_thunk_internal.h: In lambda function: ./xla/backends/cpu/runtime/convolution_thunk_internal.h:345:71: error: no matching function for call to ‘tsl::CountDownAsyncValueRef<tsl::Chain>::CountDown() const’ 345 | auto on_done = [count_down]() mutable { count_down.CountDown(); }; | ~~~~~~~~~~~~~~~~~~~~^~ In file included from ./xla/backends/cpu/runtime/convolution_thunk_internal.h:26, from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(size_t, const absl::lts_20230802::Status&) [with T = tsl::Chain; size_t = long unsigned int]’ 867 | bool CountDown(size_t count, const absl::Status& status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate expects 2 arguments, 0 provided ./xla/tsl/concurrency/async_value_ref.h:919:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(absl::lts_20230802::Status) [with T = tsl::Chain]’ (near match) 919 | bool CountDown(absl::Status status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:919:8: note: passing ‘const tsl::CountDownAsyncValueRef<tsl::Chain>*’ as ‘this’ argument discards qualifiers ``` Copybara import of the project: -- 69268a6 by Milica Makevic <[email protected]>: Allow modification of captured variable in nested lambda Merging this change closes #22572 FUTURE_COPYBARA_INTEGRATE_REVIEW=#22572 from ROCm:ci_build_fix_250211 69268a6 PiperOrigin-RevId: 725970892
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Feb 13, 2025
Imported from GitHub PR openxla/xla#22572 After this change openxla/xla@8e6b84b, following build error occurred: ``` In file included from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/backends/cpu/runtime/convolution_thunk_internal.h: In lambda function: ./xla/backends/cpu/runtime/convolution_thunk_internal.h:345:71: error: no matching function for call to ‘tsl::CountDownAsyncValueRef<tsl::Chain>::CountDown() const’ 345 | auto on_done = [count_down]() mutable { count_down.CountDown(); }; | ~~~~~~~~~~~~~~~~~~~~^~ In file included from ./xla/backends/cpu/runtime/convolution_thunk_internal.h:26, from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(size_t, const absl::lts_20230802::Status&) [with T = tsl::Chain; size_t = long unsigned int]’ 867 | bool CountDown(size_t count, const absl::Status& status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate expects 2 arguments, 0 provided ./xla/tsl/concurrency/async_value_ref.h:919:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(absl::lts_20230802::Status) [with T = tsl::Chain]’ (near match) 919 | bool CountDown(absl::Status status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:919:8: note: passing ‘const tsl::CountDownAsyncValueRef<tsl::Chain>*’ as ‘this’ argument discards qualifiers ``` Copybara import of the project: -- 69268a699eb07efb65be4e42087f75d504f750a6 by Milica Makevic <[email protected]>: Allow modification of captured variable in nested lambda Merging this change closes #22572 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#22572 from ROCm:ci_build_fix_250211 69268a699eb07efb65be4e42087f75d504f750a6 PiperOrigin-RevId: 725970892
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
Imported from GitHub PR #22572 After this change 8e6b84b, following build error occurred: ``` In file included from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/backends/cpu/runtime/convolution_thunk_internal.h: In lambda function: ./xla/backends/cpu/runtime/convolution_thunk_internal.h:345:71: error: no matching function for call to ‘tsl::CountDownAsyncValueRef<tsl::Chain>::CountDown() const’ 345 | auto on_done = [count_down]() mutable { count_down.CountDown(); }; | ~~~~~~~~~~~~~~~~~~~~^~ In file included from ./xla/backends/cpu/runtime/convolution_thunk_internal.h:26, from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(size_t, const absl::lts_20230802::Status&) [with T = tsl::Chain; size_t = long unsigned int]’ 867 | bool CountDown(size_t count, const absl::Status& status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate expects 2 arguments, 0 provided ./xla/tsl/concurrency/async_value_ref.h:919:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(absl::lts_20230802::Status) [with T = tsl::Chain]’ (near match) 919 | bool CountDown(absl::Status status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:919:8: note: passing ‘const tsl::CountDownAsyncValueRef<tsl::Chain>*’ as ‘this’ argument discards qualifiers ``` Copybara import of the project: -- 69268a6 by Milica Makevic <[email protected]>: Allow modification of captured variable in nested lambda Merging this change closes #22572 FUTURE_COPYBARA_INTEGRATE_REVIEW=#22572 from ROCm:ci_build_fix_250211 69268a6 PiperOrigin-RevId: 725970892
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
Imported from GitHub PR #22572 After this change 8e6b84b, following build error occurred: ``` In file included from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/backends/cpu/runtime/convolution_thunk_internal.h: In lambda function: ./xla/backends/cpu/runtime/convolution_thunk_internal.h:345:71: error: no matching function for call to ‘tsl::CountDownAsyncValueRef<tsl::Chain>::CountDown() const’ 345 | auto on_done = [count_down]() mutable { count_down.CountDown(); }; | ~~~~~~~~~~~~~~~~~~~~^~ In file included from ./xla/backends/cpu/runtime/convolution_thunk_internal.h:26, from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(size_t, const absl::lts_20230802::Status&) [with T = tsl::Chain; size_t = long unsigned int]’ 867 | bool CountDown(size_t count, const absl::Status& status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate expects 2 arguments, 0 provided ./xla/tsl/concurrency/async_value_ref.h:919:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(absl::lts_20230802::Status) [with T = tsl::Chain]’ (near match) 919 | bool CountDown(absl::Status status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:919:8: note: passing ‘const tsl::CountDownAsyncValueRef<tsl::Chain>*’ as ‘this’ argument discards qualifiers ``` Copybara import of the project: -- 69268a6 by Milica Makevic <[email protected]>: Allow modification of captured variable in nested lambda Merging this change closes #22572 FUTURE_COPYBARA_INTEGRATE_REVIEW=#22572 from ROCm:ci_build_fix_250211 69268a6 PiperOrigin-RevId: 725970892
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Feb 13, 2025
Imported from GitHub PR openxla/xla#22572 After this change openxla/xla@8e6b84b, following build error occurred: ``` In file included from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/backends/cpu/runtime/convolution_thunk_internal.h: In lambda function: ./xla/backends/cpu/runtime/convolution_thunk_internal.h:345:71: error: no matching function for call to ‘tsl::CountDownAsyncValueRef<tsl::Chain>::CountDown() const’ 345 | auto on_done = [count_down]() mutable { count_down.CountDown(); }; | ~~~~~~~~~~~~~~~~~~~~^~ In file included from ./xla/backends/cpu/runtime/convolution_thunk_internal.h:26, from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(size_t, const absl::lts_20230802::Status&) [with T = tsl::Chain; size_t = long unsigned int]’ 867 | bool CountDown(size_t count, const absl::Status& status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate expects 2 arguments, 0 provided ./xla/tsl/concurrency/async_value_ref.h:919:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(absl::lts_20230802::Status) [with T = tsl::Chain]’ (near match) 919 | bool CountDown(absl::Status status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:919:8: note: passing ‘const tsl::CountDownAsyncValueRef<tsl::Chain>*’ as ‘this’ argument discards qualifiers ``` Copybara import of the project: -- 69268a699eb07efb65be4e42087f75d504f750a6 by Milica Makevic <[email protected]>: Allow modification of captured variable in nested lambda Merging this change closes #22572 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#22572 from ROCm:ci_build_fix_250211 69268a699eb07efb65be4e42087f75d504f750a6 PiperOrigin-RevId: 725970892
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Feb 13, 2025
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#22572 from ROCm:ci_build_fix_250211 69268a699eb07efb65be4e42087f75d504f750a6 PiperOrigin-RevId: 726347944
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Feb 13, 2025
Imported from GitHub PR openxla/xla#22572 After this change openxla/xla@8e6b84b, following build error occurred: ``` In file included from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/backends/cpu/runtime/convolution_thunk_internal.h: In lambda function: ./xla/backends/cpu/runtime/convolution_thunk_internal.h:345:71: error: no matching function for call to ‘tsl::CountDownAsyncValueRef<tsl::Chain>::CountDown() const’ 345 | auto on_done = [count_down]() mutable { count_down.CountDown(); }; | ~~~~~~~~~~~~~~~~~~~~^~ In file included from ./xla/backends/cpu/runtime/convolution_thunk_internal.h:26, from xla/backends/cpu/runtime/convolution_thunk_f16.cc:16: ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(size_t, const absl::lts_20230802::Status&) [with T = tsl::Chain; size_t = long unsigned int]’ 867 | bool CountDown(size_t count, const absl::Status& status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:867:8: note: candidate expects 2 arguments, 0 provided ./xla/tsl/concurrency/async_value_ref.h:919:8: note: candidate: ‘bool tsl::CountDownAsyncValueRef<T>::CountDown(absl::lts_20230802::Status) [with T = tsl::Chain]’ (near match) 919 | bool CountDown(absl::Status status = absl::OkStatus()) { | ^~~~~~~~~ ./xla/tsl/concurrency/async_value_ref.h:919:8: note: passing ‘const tsl::CountDownAsyncValueRef<tsl::Chain>*’ as ‘this’ argument discards qualifiers ``` Copybara import of the project: -- 69268a699eb07efb65be4e42087f75d504f750a6 by Milica Makevic <[email protected]>: Allow modification of captured variable in nested lambda Merging this change closes #22572 PiperOrigin-RevId: 726463713
gharibian
added a commit
to gharibian/serving
that referenced
this pull request
Apr 9, 2025
gharibian
added a commit
to tensorflow/serving
that referenced
this pull request
Apr 9, 2025
Added github.com/openxla/xla/pull/22572 into tensorflow.patch to resolve breakage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change 8e6b84b, following build error occurred: