6in4: tunnel enpoint update is totally broken #3248
Description
# logread | grep -i 6in4
Tue Sep 27 15:42:37 2016 daemon.notice netifd: IP tunnel '6in4-wan6' link is up
Tue Sep 27 15:42:38 2016 user.notice 6in4-wan6: update 1/3: uclient-fetch: local: line 2: not in a function
Tue Sep 27 15:42:38 2016 user.notice 6in4-wan6: update 1/3: timeout
Tue Sep 27 15:42:38 2016 user.notice firewall: Reloading firewall due to ifup of wan6 (6in4-wan6)
Tue Sep 27 15:42:43 2016 user.notice 6in4-wan6: update 2/3: uclient-fetch: local: line 2: not in a function
Tue Sep 27 15:42:43 2016 user.notice 6in4-wan6: update 2/3: timeout
Wed Sep 28 12:52:03 2016 user.notice 6in4-wan6: update 3/3: uclient-fetch: local: line 2: not in a function
Wed Sep 28 12:52:03 2016 user.notice 6in4-wan6: update 3/3: timeout
Wed Sep 28 12:52:08 2016 user.notice 6in4-wan6: update failed
Tested on latest ar71xx from 26.09 and 28.09. Stable releases is also affected because have the same bad URL format:
- https://forums.he.net/index.php?topic=1994.0
- https://dev.openwrt.org/browser/trunk/package/network/ipv6/6in4/files/6in4.sh#L94
L94 need to be changed to
local url="http://ipv4.tunnelbroker.net/nic/update?username=$username&password=$password&hostname=$tunnelid"
Also (according to logs) problem with including functions.